Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/compiler/common-operator.h

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moar rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/common-operator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/common-operator.h
diff --git a/src/compiler/common-operator.h b/src/compiler/common-operator.h
index 8c7d26608c2453d484729b4071f1825abf0e0a9f..211e4e4843e168f4929aa7173e5e270fad5f52fc 100644
--- a/src/compiler/common-operator.h
+++ b/src/compiler/common-operator.h
@@ -71,15 +71,15 @@ std::ostream& operator<<(std::ostream&, IfExceptionHint);
class SelectParameters final {
public:
- explicit SelectParameters(MachineType type,
+ explicit SelectParameters(MachineRepresentation representation,
BranchHint hint = BranchHint::kNone)
- : type_(type), hint_(hint) {}
+ : representation_(representation), hint_(hint) {}
- MachineType type() const { return type_; }
+ MachineRepresentation representation() const { return representation_; }
BranchHint hint() const { return hint_; }
private:
- const MachineType type_;
+ const MachineRepresentation representation_;
const BranchHint hint_;
};
@@ -95,6 +95,8 @@ SelectParameters const& SelectParametersOf(const Operator* const);
size_t ProjectionIndexOf(const Operator* const);
+MachineRepresentation PhiRepresentationOf(const Operator* const);
+
// The {IrOpcode::kParameter} opcode represents an incoming parameter to the
// function. This class bundles the index and a debug name for such operators.
@@ -155,8 +157,9 @@ class CommonOperatorBuilder final : public ZoneObject {
const Operator* NumberConstant(volatile double);
const Operator* HeapConstant(const Handle<HeapObject>&);
- const Operator* Select(MachineType, BranchHint = BranchHint::kNone);
- const Operator* Phi(MachineType type, int value_input_count);
+ const Operator* Select(MachineRepresentation, BranchHint = BranchHint::kNone);
+ const Operator* Phi(MachineRepresentation representation,
+ int value_input_count);
const Operator* EffectPhi(int effect_input_count);
const Operator* EffectSet(int arguments);
const Operator* Guard(Type* type);
« no previous file with comments | « src/compiler/code-stub-assembler.cc ('k') | src/compiler/common-operator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698