Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: test/cctest/compiler/test-multiple-return.cc

Issue 1513543003: [turbofan] Make MachineType a pair of enums. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Moar rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/compiler/test-machine-operator-reducer.cc ('k') | test/cctest/compiler/test-osr.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <cmath> 5 #include <cmath>
6 #include <functional> 6 #include <functional>
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 15 matching lines...) Expand all
26 CallDescriptor* GetCallDescriptor(Zone* zone, int return_count, 26 CallDescriptor* GetCallDescriptor(Zone* zone, int return_count,
27 int param_count) { 27 int param_count) {
28 MachineSignature::Builder msig(zone, return_count, param_count); 28 MachineSignature::Builder msig(zone, return_count, param_count);
29 LocationSignature::Builder locations(zone, return_count, param_count); 29 LocationSignature::Builder locations(zone, return_count, param_count);
30 const RegisterConfiguration* config = 30 const RegisterConfiguration* config =
31 RegisterConfiguration::ArchDefault(RegisterConfiguration::TURBOFAN); 31 RegisterConfiguration::ArchDefault(RegisterConfiguration::TURBOFAN);
32 32
33 // Add return location(s). 33 // Add return location(s).
34 CHECK(return_count <= config->num_allocatable_general_registers()); 34 CHECK(return_count <= config->num_allocatable_general_registers());
35 for (int i = 0; i < return_count; i++) { 35 for (int i = 0; i < return_count; i++) {
36 msig.AddReturn(kMachInt32); 36 msig.AddReturn(MachineType::Int32());
37 locations.AddReturn( 37 locations.AddReturn(
38 LinkageLocation::ForRegister(config->allocatable_general_codes()[i])); 38 LinkageLocation::ForRegister(config->allocatable_general_codes()[i]));
39 } 39 }
40 40
41 // Add register and/or stack parameter(s). 41 // Add register and/or stack parameter(s).
42 CHECK(param_count <= config->num_allocatable_general_registers()); 42 CHECK(param_count <= config->num_allocatable_general_registers());
43 for (int i = 0; i < param_count; i++) { 43 for (int i = 0; i < param_count; i++) {
44 msig.AddParam(kMachInt32); 44 msig.AddParam(MachineType::Int32());
45 locations.AddParam( 45 locations.AddParam(
46 LinkageLocation::ForRegister(config->allocatable_general_codes()[i])); 46 LinkageLocation::ForRegister(config->allocatable_general_codes()[i]));
47 } 47 }
48 48
49 const RegList kCalleeSaveRegisters = 0; 49 const RegList kCalleeSaveRegisters = 0;
50 const RegList kCalleeSaveFPRegisters = 0; 50 const RegList kCalleeSaveFPRegisters = 0;
51 51
52 // The target for WASM calls is always a code object. 52 // The target for WASM calls is always a code object.
53 MachineType target_type = kMachAnyTagged; 53 MachineType target_type = MachineType::AnyTagged();
54 LinkageLocation target_loc = LinkageLocation::ForAnyRegister(); 54 LinkageLocation target_loc = LinkageLocation::ForAnyRegister();
55 return new (zone) CallDescriptor( // -- 55 return new (zone) CallDescriptor( // --
56 CallDescriptor::kCallCodeObject, // kind 56 CallDescriptor::kCallCodeObject, // kind
57 target_type, // target MachineType 57 target_type, // target MachineType
58 target_loc, // target location 58 target_loc, // target location
59 msig.Build(), // machine_sig 59 msig.Build(), // machine_sig
60 locations.Build(), // location_sig 60 locations.Build(), // location_sig
61 0, // js_parameter_count 61 0, // js_parameter_count
62 compiler::Operator::kNoProperties, // properties 62 compiler::Operator::kNoProperties, // properties
63 kCalleeSaveRegisters, // callee-saved registers 63 kCalleeSaveRegisters, // callee-saved registers
64 kCalleeSaveFPRegisters, // callee-saved fp regs 64 kCalleeSaveFPRegisters, // callee-saved fp regs
65 CallDescriptor::kNoFlags, // flags 65 CallDescriptor::kNoFlags, // flags
66 "c-call"); 66 "c-call");
67 } 67 }
68 } // namespace 68 } // namespace
69 69
70 70
71 TEST(ReturnThreeValues) { 71 TEST(ReturnThreeValues) {
72 Zone zone; 72 Zone zone;
73 CallDescriptor* desc = GetCallDescriptor(&zone, 3, 2); 73 CallDescriptor* desc = GetCallDescriptor(&zone, 3, 2);
74 HandleAndZoneScope handles; 74 HandleAndZoneScope handles;
75 RawMachineAssembler m(handles.main_isolate(), 75 RawMachineAssembler m(handles.main_isolate(),
76 new (handles.main_zone()) Graph(handles.main_zone()), 76 new (handles.main_zone()) Graph(handles.main_zone()),
77 desc, kMachPtr, 77 desc, MachineType::PointerRepresentation(),
78 InstructionSelector::SupportedMachineOperatorFlags()); 78 InstructionSelector::SupportedMachineOperatorFlags());
79 79
80 Node* p0 = m.Parameter(0); 80 Node* p0 = m.Parameter(0);
81 Node* p1 = m.Parameter(1); 81 Node* p1 = m.Parameter(1);
82 Node* add = m.Int32Add(p0, p1); 82 Node* add = m.Int32Add(p0, p1);
83 Node* sub = m.Int32Sub(p0, p1); 83 Node* sub = m.Int32Sub(p0, p1);
84 Node* mul = m.Int32Mul(p0, p1); 84 Node* mul = m.Int32Mul(p0, p1);
85 m.Return(add, sub, mul); 85 m.Return(add, sub, mul);
86 86
87 CompilationInfo info("testing", handles.main_isolate(), handles.main_zone()); 87 CompilationInfo info("testing", handles.main_isolate(), handles.main_zone());
(...skipping 21 matching lines...) Expand all
109 OFStream os(stdout); 109 OFStream os(stdout);
110 code2->Disassemble("three_value_call", os); 110 code2->Disassemble("three_value_call", os);
111 } 111 }
112 #endif 112 #endif
113 CHECK_EQ((123 + 456) + (123 - 456) + (123 * 456), mt.Call()); 113 CHECK_EQ((123 + 456) + (123 - 456) + (123 * 456), mt.Call());
114 } 114 }
115 115
116 } // namespace compiler 116 } // namespace compiler
117 } // namespace internal 117 } // namespace internal
118 } // namespace v8 118 } // namespace v8
OLDNEW
« no previous file with comments | « test/cctest/compiler/test-machine-operator-reducer.cc ('k') | test/cctest/compiler/test-osr.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698