Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed)

Created:
5 years ago by Jarin
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Store nodes use only MachineRepresentation, not MachineType. Committed: https://crrev.com/56673804e026b297a5165e6f807f55aaaad6c6ee Cr-Commit-Position: refs/heads/master@{#32803}

Patch Set 1 #

Patch Set 2 : Fix wasm, rebase #

Patch Set 3 : Fix & rebase #

Patch Set 4 : please mips64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -212 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/basic-block-instrumentor.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/change-lowering.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 2 chunks +6 lines, -5 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 2 8 chunks +38 lines, -20 lines 0 comments Download
M src/compiler/machine-operator-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/codegen-tester.cc View 5 chunks +10 lines, -7 lines 0 comments Download
M test/cctest/compiler/test-changes-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-machine-operator-reducer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 2 30 chunks +35 lines, -34 lines 0 comments Download
M test/cctest/compiler/test-run-native-calls.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/unittests/compiler/change-lowering-unittest.cc View 7 chunks +39 lines, -37 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M test/unittests/compiler/interpreter-assembler-unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/compiler/machine-operator-reducer-unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 3 chunks +15 lines, -6 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jarin
Could you take a look, please?
5 years ago (2015-12-11 14:11:13 UTC) #2
Benedikt Meurer
Nice. LGTM.
5 years ago (2015-12-11 14:38:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1513383003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1513383003/60001
5 years ago (2015-12-11 14:45:21 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-11 15:34:05 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-11 15:34:25 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/56673804e026b297a5165e6f807f55aaaad6c6ee
Cr-Commit-Position: refs/heads/master@{#32803}

Powered by Google App Engine
This is Rietveld 408576698