test/unittests/compiler/machine-operator-reducer-unittest.cc - Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/machine-operator-reducer-unittest.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: please mips64 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/compiler/interpreter-assembler-unittest.cc ('k') | test/unittests/compiler/machine-operator-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/machine-operator-reducer-unittest.cc

diff --git a/test/unittests/compiler/machine-operator-reducer-unittest.cc b/test/unittests/compiler/machine-operator-reducer-unittest.cc

index 34b3792c911a3f806fccc50692d1fe2bc7387a63..2feba2ef7f56f7f699e386b340d25dec2376a2a5 100644

--- a/test/unittests/compiler/machine-operator-reducer-unittest.cc

+++ b/test/unittests/compiler/machine-operator-reducer-unittest.cc

@@ -1560,7 +1560,7 @@ TEST_F(MachineOperatorReducerTest, Float64LessThanOrEqualWithFloat32Constant) {

TEST_F(MachineOperatorReducerTest, StoreRepWord8WithWord32And) {

- const StoreRepresentation rep(MachineType::Uint8(), kNoWriteBarrier);

+ const StoreRepresentation rep(MachineRepresentation::kWord8, kNoWriteBarrier);

Node* const base = Parameter(0);

Node* const index = Parameter(1);

Node* const value = Parameter(2);

@@ -1582,7 +1582,7 @@ TEST_F(MachineOperatorReducerTest, StoreRepWord8WithWord32And) {

TEST_F(MachineOperatorReducerTest, StoreRepWord8WithWord32SarAndWord32Shl) {

- const StoreRepresentation rep(MachineType::Uint8(), kNoWriteBarrier);

+ const StoreRepresentation rep(MachineRepresentation::kWord8, kNoWriteBarrier);

Node* const base = Parameter(0);

Node* const index = Parameter(1);

Node* const value = Parameter(2);

@@ -1606,7 +1606,8 @@ TEST_F(MachineOperatorReducerTest, StoreRepWord8WithWord32SarAndWord32Shl) {

TEST_F(MachineOperatorReducerTest, StoreRepWord16WithWord32And) {

- const StoreRepresentation rep(MachineType::Uint16(), kNoWriteBarrier);

+ const StoreRepresentation rep(MachineRepresentation::kWord16,

+ kNoWriteBarrier);

Node* const base = Parameter(0);

Node* const index = Parameter(1);

Node* const value = Parameter(2);

@@ -1628,7 +1629,8 @@ TEST_F(MachineOperatorReducerTest, StoreRepWord16WithWord32And) {

TEST_F(MachineOperatorReducerTest, StoreRepWord16WithWord32SarAndWord32Shl) {

- const StoreRepresentation rep(MachineType::Uint16(), kNoWriteBarrier);

+ const StoreRepresentation rep(MachineRepresentation::kWord16,

+ kNoWriteBarrier);

Node* const base = Parameter(0);

Node* const index = Parameter(1);

Node* const value = Parameter(2);

« no previous file with comments | « test/unittests/compiler/interpreter-assembler-unittest.cc ('k') | test/unittests/compiler/machine-operator-unittest.cc » ('j') | no next file with comments »