[turbofan] Store nodes use only MachineRepresentation, not MachineType.

test/unittests/compiler/change-lowering-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 #include "src/compiler/change-lowering.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/linkage.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/simplified-operator.h"
@@ skipping 174 matching lines @@
   FieldAccess access = {kTaggedBase, FixedArrayBase::kHeaderSize,
                         Handle<Name>::null(), Type::Any(),
                         MachineType::AnyTagged()};
   Node* p0 = Parameter(Type::TaggedPointer());
   Node* p1 = Parameter(Type::TaggedSigned());
   Node* store = graph()->NewNode(simplified()->StoreField(access), p0, p1,
                                  graph()->start(), graph()->start());
   Reduction r = Reduce(store);
 
   ASSERT_TRUE(r.Changed());
-  EXPECT_THAT(
-      r.replacement(),
-      IsStore(StoreRepresentation(MachineType::AnyTagged(), kNoWriteBarrier),
-              p0, IsIntPtrConstant(access.offset - access.tag()), p1,
-              graph()->start(), graph()->start()));
+  EXPECT_THAT(r.replacement(),
+              IsStore(StoreRepresentation(MachineRepresentation::kTagged,
+                                          kNoWriteBarrier),
+                      p0, IsIntPtrConstant(access.offset - access.tag()), p1,
+                      graph()->start(), graph()->start()));
 }
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, StoreFieldTagged) {
   FieldAccess access = {kTaggedBase, FixedArrayBase::kHeaderSize,
                         Handle<Name>::null(), Type::Any(),
                         MachineType::AnyTagged()};
   Node* p0 = Parameter(Type::TaggedPointer());
   Node* p1 = Parameter(Type::Tagged());
   Node* store = graph()->NewNode(simplified()->StoreField(access), p0, p1,
                                  graph()->start(), graph()->start());
   Reduction r = Reduce(store);
 
   ASSERT_TRUE(r.Changed());
-  EXPECT_THAT(
-      r.replacement(),
-      IsStore(StoreRepresentation(MachineType::AnyTagged(), kFullWriteBarrier),
-              p0, IsIntPtrConstant(access.offset - access.tag()), p1,
-              graph()->start(), graph()->start()));
+  EXPECT_THAT(r.replacement(),
+              IsStore(StoreRepresentation(MachineRepresentation::kTagged,
+                                          kFullWriteBarrier),
+                      p0, IsIntPtrConstant(access.offset - access.tag()), p1,
+                      graph()->start(), graph()->start()));
 }
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, LoadField) {
   FieldAccess access = {kTaggedBase, FixedArrayBase::kHeaderSize,
                         Handle<Name>::null(), Type::Any(),
                         MachineType::AnyTagged()};
   Node* p0 = Parameter(Type::TaggedPointer());
   Node* load = graph()->NewNode(simplified()->LoadField(access), p0,
                                 graph()->start(), graph()->start());
@@ skipping 21 matching lines @@
   const int element_size_shift =
       ElementSizeLog2Of(access.machine_type.representation());
   ASSERT_TRUE(r.Changed());
   Matcher<Node*> index_match =
       IsInt32Add(IsWord32Shl(p1, IsInt32Constant(element_size_shift)),
                  IsInt32Constant(access.header_size - access.tag()));
   if (!Is32()) {
     index_match = IsChangeUint32ToUint64(index_match);
   }
 
-  EXPECT_THAT(
-      r.replacement(),
-      IsStore(StoreRepresentation(MachineType::AnyTagged(), kFullWriteBarrier),
-              p0, index_match, p2, graph()->start(), graph()->start()));
+  EXPECT_THAT(r.replacement(),
+              IsStore(StoreRepresentation(MachineRepresentation::kTagged,
+                                          kFullWriteBarrier),
+                      p0, index_match, p2, graph()->start(), graph()->start()));
 }
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, StoreElementUint8) {
   ElementAccess access = {kTaggedBase, FixedArrayBase::kHeaderSize,
                           Type::Signed32(), MachineType::Uint8()};
   Node* p0 = Parameter(Type::TaggedPointer());
   Node* p1 = Parameter(Type::Signed32());
   Node* p2 = Parameter(Type::Signed32());
   Node* store = graph()->NewNode(simplified()->StoreElement(access), p0, p1, p2,
                                  graph()->start(), graph()->start());
   Reduction r = Reduce(store);
 
   ASSERT_TRUE(r.Changed());
   Matcher<Node*> index_match =
       IsInt32Add(p1, IsInt32Constant(access.header_size - access.tag()));
   if (!Is32()) {
     index_match = IsChangeUint32ToUint64(index_match);
   }
 
-  EXPECT_THAT(
-      r.replacement(),
-      IsStore(StoreRepresentation(MachineType::Uint8(), kNoWriteBarrier), p0,
-              index_match, p2, graph()->start(), graph()->start()));
+  EXPECT_THAT(r.replacement(),
+              IsStore(StoreRepresentation(MachineRepresentation::kWord8,
+                                          kNoWriteBarrier),
+                      p0, index_match, p2, graph()->start(), graph()->start()));
 }
 
 
 TARGET_TEST_P(ChangeLoweringCommonTest, LoadElementTagged) {
   ElementAccess access = {kTaggedBase, FixedArrayBase::kHeaderSize, Type::Any(),
                           MachineType::AnyTagged()};
   Node* p0 = Parameter(Type::TaggedPointer());
   Node* p1 = Parameter(Type::Signed32());
   Node* load = graph()->NewNode(simplified()->LoadElement(access), p0, p1,
                                 graph()->start(), graph()->start());
@@ skipping 66 matching lines @@
 
 
 TARGET_TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
   Node* value = Parameter(Type::Integral32());
   Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), value);
   Reduction r = Reduce(node);
   ASSERT_TRUE(r.Changed());
   Capture<Node*> add, branch, heap_number, if_true;
   EXPECT_THAT(
       r.replacement(),
-      IsPhi(
-          MachineRepresentation::kTagged,
-          IsFinishRegion(
-              AllOf(CaptureEq(&heap_number),
-                    IsAllocateHeapNumber(_, CaptureEq(&if_true))),
-              IsStore(
-                  StoreRepresentation(MachineType::Float64(), kNoWriteBarrier),
-                  CaptureEq(&heap_number),
-                  IsIntPtrConstant(HeapNumber::kValueOffset - kHeapObjectTag),
-                  IsChangeInt32ToFloat64(value), CaptureEq(&heap_number),
-                  CaptureEq(&if_true))),
-          IsProjection(
-              0, AllOf(CaptureEq(&add), IsInt32AddWithOverflow(value, value))),
-          IsMerge(AllOf(CaptureEq(&if_true), IsIfTrue(CaptureEq(&branch))),
-                  IsIfFalse(AllOf(CaptureEq(&branch),
-                                  IsBranch(IsProjection(1, CaptureEq(&add)),
-                                           graph()->start()))))));
+      IsPhi(MachineRepresentation::kTagged,
+            IsFinishRegion(
+                AllOf(CaptureEq(&heap_number),
+                      IsAllocateHeapNumber(_, CaptureEq(&if_true))),
+                IsStore(
+                    StoreRepresentation(MachineRepresentation::kFloat64,
+                                        kNoWriteBarrier),
+                    CaptureEq(&heap_number),
+                    IsIntPtrConstant(HeapNumber::kValueOffset - kHeapObjectTag),
+                    IsChangeInt32ToFloat64(value), CaptureEq(&heap_number),
+                    CaptureEq(&if_true))),
+            IsProjection(0, AllOf(CaptureEq(&add),
+                                  IsInt32AddWithOverflow(value, value))),
+            IsMerge(AllOf(CaptureEq(&if_true), IsIfTrue(CaptureEq(&branch))),
+                    IsIfFalse(AllOf(CaptureEq(&branch),
+                                    IsBranch(IsProjection(1, CaptureEq(&add)),
+                                             graph()->start()))))));
 }
 
 
 TARGET_TEST_F(ChangeLowering32Test, ChangeTaggedToFloat64) {
   STATIC_ASSERT(kSmiTag == 0);
   STATIC_ASSERT(kSmiTagSize == 1);
 
   Node* value = Parameter(Type::Number());
   Node* node = graph()->NewNode(simplified()->ChangeTaggedToFloat64(), value);
   Reduction r = Reduce(node);
@@ skipping 72 matching lines @@
   Capture<Node*> branch, heap_number, if_false;
   EXPECT_THAT(
       r.replacement(),
       IsPhi(
           MachineRepresentation::kTagged,
           IsWord32Shl(value, IsInt32Constant(kSmiTagSize + kSmiShiftSize)),
           IsFinishRegion(
               AllOf(CaptureEq(&heap_number),
                     IsAllocateHeapNumber(_, CaptureEq(&if_false))),
               IsStore(
-                  StoreRepresentation(MachineType::Float64(), kNoWriteBarrier),
+                  StoreRepresentation(MachineRepresentation::kFloat64,
+                                      kNoWriteBarrier),
                   CaptureEq(&heap_number),
                   IsInt32Constant(HeapNumber::kValueOffset - kHeapObjectTag),
                   IsChangeUint32ToFloat64(value), CaptureEq(&heap_number),
                   CaptureEq(&if_false))),
           IsMerge(IsIfTrue(AllOf(
                       CaptureEq(&branch),
                       IsBranch(IsUint32LessThanOrEqual(
                                    value, IsInt32Constant(Smi::kMaxValue)),
                                graph()->start()))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
@@ skipping 107 matching lines @@
   EXPECT_THAT(
       r.replacement(),
       IsPhi(
           MachineRepresentation::kTagged,
           IsWord64Shl(IsChangeUint32ToUint64(value),
                       IsInt64Constant(kSmiTagSize + kSmiShiftSize)),
           IsFinishRegion(
               AllOf(CaptureEq(&heap_number),
                     IsAllocateHeapNumber(_, CaptureEq(&if_false))),
               IsStore(
-                  StoreRepresentation(MachineType::Float64(), kNoWriteBarrier),
+                  StoreRepresentation(MachineRepresentation::kFloat64,
+                                      kNoWriteBarrier),
                   CaptureEq(&heap_number),
                   IsInt64Constant(HeapNumber::kValueOffset - kHeapObjectTag),
                   IsChangeUint32ToFloat64(value), CaptureEq(&heap_number),
                   CaptureEq(&if_false))),
           IsMerge(IsIfTrue(AllOf(
                       CaptureEq(&branch),
                       IsBranch(IsUint32LessThanOrEqual(
                                    value, IsInt32Constant(Smi::kMaxValue)),
                                graph()->start()))),
                   AllOf(CaptureEq(&if_false), IsIfFalse(CaptureEq(&branch))))));
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8