Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: please mips64 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index d2f2eda136a7b72daae0df5ac18625df26a65bec..cc562676e54a297e0959153cd059fc7546dec3c8 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -1482,7 +1482,7 @@ Node* WasmGraphBuilder::StoreGlobal(uint32_t index, Node* val) {
Node* addr = jsgraph()->IntPtrConstant(
module_->globals_area + module_->module->globals->at(index).offset);
const Operator* op = jsgraph()->machine()->Store(
- StoreRepresentation(mem_type, kNoWriteBarrier));
+ StoreRepresentation(mem_type.representation(), kNoWriteBarrier));
Node* node = graph()->NewNode(op, addr, jsgraph()->Int32Constant(0), val,
*effect_, *control_);
*effect_ = node;
@@ -1555,13 +1555,14 @@ Node* WasmGraphBuilder::StoreMem(MachineType memtype, Node* index,
if (module_ && module_->asm_js) {
// asm.js semantics use CheckedStore (i.e. ignore OOB writes).
DCHECK_EQ(0, offset);
- const Operator* op = jsgraph()->machine()->CheckedStore(memtype);
+ const Operator* op =
+ jsgraph()->machine()->CheckedStore(memtype.representation());
store = graph()->NewNode(op, MemBuffer(0), index, MemSize(0), val, *effect_,
*control_);
} else {
// WASM semantics throw on OOB. Introduce explicit bounds check.
BoundsCheckMem(memtype, index, offset);
- StoreRepresentation rep(memtype, kNoWriteBarrier);
+ StoreRepresentation rep(memtype.representation(), kNoWriteBarrier);
store =
graph()->NewNode(jsgraph()->machine()->Store(rep), MemBuffer(offset),
index, val, *effect_, *control_);
« no previous file with comments | « src/compiler/simplified-lowering.cc ('k') | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698