test/unittests/compiler/mips/instruction-selector-mips-unittest.cc - Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: please mips64 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/compiler/machine-operator-unittest.cc ('k') | test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

diff --git a/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc b/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

index decf1e1a3298d442629e55b4283da15d5a6facd4..51ce701674a4b4536628ab06c1ae4fa5a52f4440 100644

--- a/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

+++ b/test/unittests/compiler/mips/instruction-selector-mips-unittest.cc

@@ -880,7 +880,8 @@ TEST_P(InstructionSelectorMemoryAccessTest, StoreWithParameters) {

const MemoryAccess memacc = GetParam();

StreamBuilder m(this, MachineType::Int32(), MachineType::Pointer(),

MachineType::Int32(), memacc.type);

- m.Store(memacc.type, m.Parameter(0), m.Parameter(1), kNoWriteBarrier);

+ m.Store(memacc.type.representation(), m.Parameter(0), m.Parameter(1),

+ kNoWriteBarrier);

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -931,8 +932,8 @@ TEST_P(InstructionSelectorMemoryAccessImmTest, StoreWithImmediateIndex) {

TRACED_FOREACH(int32_t, index, memacc.immediates) {

StreamBuilder m(this, MachineType::Int32(), MachineType::Pointer(),

memacc.type);

- m.Store(memacc.type, m.Parameter(0), m.Int32Constant(index), m.Parameter(1),

- kNoWriteBarrier);

+ m.Store(memacc.type.representation(), m.Parameter(0),

+ m.Int32Constant(index), m.Parameter(1), kNoWriteBarrier);

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(1U, s.size());

@@ -984,8 +985,8 @@ TEST_P(InstructionSelectorMemoryAccessImmMoreThan16bitTest,

TRACED_FOREACH(int32_t, index, memacc.immediates) {

StreamBuilder m(this, MachineType::Int32(), MachineType::Pointer(),

memacc.type);

- m.Store(memacc.type, m.Parameter(0), m.Int32Constant(index), m.Parameter(1),

- kNoWriteBarrier);

+ m.Store(memacc.type.representation(), m.Parameter(0),

+ m.Int32Constant(index), m.Parameter(1), kNoWriteBarrier);

m.Return(m.Int32Constant(0));

Stream s = m.Build();

ASSERT_EQ(2U, s.size());