Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: src/compiler/interpreter-assembler.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: please mips64 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/interpreter-assembler.h" 5 #include "src/compiler/interpreter-assembler.h"
6 6
7 #include <ostream> 7 #include <ostream>
8 8
9 #include "src/code-factory.h" 9 #include "src/code-factory.h"
10 #include "src/compiler/graph.h" 10 #include "src/compiler/graph.h"
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 Node* InterpreterAssembler::LoadRegister(Node* reg_index) { 121 Node* InterpreterAssembler::LoadRegister(Node* reg_index) {
122 return raw_assembler_->Load(MachineType::AnyTagged(), 122 return raw_assembler_->Load(MachineType::AnyTagged(),
123 RegisterFileRawPointer(), 123 RegisterFileRawPointer(),
124 RegisterFrameOffset(reg_index)); 124 RegisterFrameOffset(reg_index));
125 } 125 }
126 126
127 127
128 Node* InterpreterAssembler::StoreRegister(Node* value, Node* reg_index) { 128 Node* InterpreterAssembler::StoreRegister(Node* value, Node* reg_index) {
129 return raw_assembler_->Store( 129 return raw_assembler_->Store(
130 MachineType::AnyTagged(), RegisterFileRawPointer(), 130 MachineRepresentation::kTagged, RegisterFileRawPointer(),
131 RegisterFrameOffset(reg_index), value, kNoWriteBarrier); 131 RegisterFrameOffset(reg_index), value, kNoWriteBarrier);
132 } 132 }
133 133
134 134
135 Node* InterpreterAssembler::BytecodeOperand(int operand_index) { 135 Node* InterpreterAssembler::BytecodeOperand(int operand_index) {
136 DCHECK_LT(operand_index, interpreter::Bytecodes::NumberOfOperands(bytecode_)); 136 DCHECK_LT(operand_index, interpreter::Bytecodes::NumberOfOperands(bytecode_));
137 DCHECK_EQ(interpreter::OperandSize::kByte, 137 DCHECK_EQ(interpreter::OperandSize::kByte,
138 interpreter::Bytecodes::GetOperandSize(bytecode_, operand_index)); 138 interpreter::Bytecodes::GetOperandSize(bytecode_, operand_index));
139 return raw_assembler_->Load( 139 return raw_assembler_->Load(
140 MachineType::Uint8(), BytecodeArrayTaggedPointer(), 140 MachineType::Uint8(), BytecodeArrayTaggedPointer(),
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 Int32Constant(Context::kHeaderSize - kHeapObjectTag)); 343 Int32Constant(Context::kHeaderSize - kHeapObjectTag));
344 return raw_assembler_->Load(MachineType::AnyTagged(), context, offset); 344 return raw_assembler_->Load(MachineType::AnyTagged(), context, offset);
345 } 345 }
346 346
347 347
348 Node* InterpreterAssembler::StoreContextSlot(Node* context, Node* slot_index, 348 Node* InterpreterAssembler::StoreContextSlot(Node* context, Node* slot_index,
349 Node* value) { 349 Node* value) {
350 Node* offset = 350 Node* offset =
351 IntPtrAdd(WordShl(slot_index, kPointerSizeLog2), 351 IntPtrAdd(WordShl(slot_index, kPointerSizeLog2),
352 Int32Constant(Context::kHeaderSize - kHeapObjectTag)); 352 Int32Constant(Context::kHeaderSize - kHeapObjectTag));
353 return raw_assembler_->Store(MachineType::AnyTagged(), context, offset, value, 353 return raw_assembler_->Store(MachineRepresentation::kTagged, context, offset,
354 kFullWriteBarrier); 354 value, kFullWriteBarrier);
355 } 355 }
356 356
357 357
358 Node* InterpreterAssembler::LoadTypeFeedbackVector() { 358 Node* InterpreterAssembler::LoadTypeFeedbackVector() {
359 Node* function = raw_assembler_->Load( 359 Node* function = raw_assembler_->Load(
360 MachineType::AnyTagged(), RegisterFileRawPointer(), 360 MachineType::AnyTagged(), RegisterFileRawPointer(),
361 IntPtrConstant(InterpreterFrameConstants::kFunctionFromRegisterPointer)); 361 IntPtrConstant(InterpreterFrameConstants::kFunctionFromRegisterPointer));
362 Node* shared_info = 362 Node* shared_info =
363 LoadObjectField(function, JSFunction::kSharedFunctionInfoOffset); 363 LoadObjectField(function, JSFunction::kSharedFunctionInfoOffset);
364 Node* vector = 364 Node* vector =
(...skipping 271 matching lines...) Expand 10 before | Expand all | Expand 10 after
636 return raw_assembler_->call_descriptor(); 636 return raw_assembler_->call_descriptor();
637 } 637 }
638 638
639 639
640 Zone* InterpreterAssembler::zone() { return raw_assembler_->zone(); } 640 Zone* InterpreterAssembler::zone() { return raw_assembler_->zone(); }
641 641
642 642
643 } // namespace compiler 643 } // namespace compiler
644 } // namespace internal 644 } // namespace internal
645 } // namespace v8 645 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/js-generic-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698