Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: test/unittests/compiler/machine-operator-unittest.cc

Issue 1513383003: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: please mips64 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/machine-operator-unittest.cc
diff --git a/test/unittests/compiler/machine-operator-unittest.cc b/test/unittests/compiler/machine-operator-unittest.cc
index c50db98115850b6b82242248f891bfc57d5c1e60..59eb484dabfd4f5fa4d8852beea373824a33623e 100644
--- a/test/unittests/compiler/machine-operator-unittest.cc
+++ b/test/unittests/compiler/machine-operator-unittest.cc
@@ -43,6 +43,13 @@ const MachineType kMachineTypesForAccess[] = {
MachineType::Int32(), MachineType::Uint32(), MachineType::Int64(),
MachineType::Uint64(), MachineType::AnyTagged()};
+
+const MachineRepresentation kRepresentationsForStore[] = {
+ MachineRepresentation::kFloat32, MachineRepresentation::kFloat64,
+ MachineRepresentation::kWord8, MachineRepresentation::kWord16,
+ MachineRepresentation::kWord32, MachineRepresentation::kWord64,
+ MachineRepresentation::kTagged};
+
} // namespace
@@ -101,14 +108,16 @@ INSTANTIATE_TEST_CASE_P(
class MachineStoreOperatorTest
: public MachineOperatorTestWithParam<
- ::testing::tuple<MachineType, WriteBarrierKind> > {
+ ::testing::tuple<MachineRepresentation, WriteBarrierKind> > {
protected:
StoreRepresentation GetParam() const {
return StoreRepresentation(
- ::testing::get<0>(MachineOperatorTestWithParam<
- ::testing::tuple<MachineType, WriteBarrierKind> >::GetParam()),
- ::testing::get<1>(MachineOperatorTestWithParam<
- ::testing::tuple<MachineType, WriteBarrierKind> >::GetParam()));
+ ::testing::get<0>(
+ MachineOperatorTestWithParam< ::testing::tuple<
+ MachineRepresentation, WriteBarrierKind> >::GetParam()),
+ ::testing::get<1>(
+ MachineOperatorTestWithParam< ::testing::tuple<
+ MachineRepresentation, WriteBarrierKind> >::GetParam()));
}
};
@@ -152,7 +161,7 @@ INSTANTIATE_TEST_CASE_P(
MachineOperatorTest, MachineStoreOperatorTest,
::testing::Combine(
::testing::ValuesIn(kMachineReps),
- ::testing::Combine(::testing::ValuesIn(kMachineTypesForAccess),
+ ::testing::Combine(::testing::ValuesIn(kRepresentationsForStore),
::testing::Values(kNoWriteBarrier,
kFullWriteBarrier))));
#endif

Powered by Google App Engine
This is Rietveld 408576698