Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : protected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -349 lines) Patch
M xfa/include/fwl/basewidget/fwl_barcode.h View 1 chunk +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_caret.h View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_checkbox.h View 1 chunk +2 lines, -7 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_combobox.h View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_datetimepicker.h View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_edit.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_listbox.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_picturebox.h View 1 chunk +1 line, -5 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_pushbutton.h View 1 chunk +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_scrollbar.h View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_spinbutton.h View 1 chunk +2 lines, -5 lines 0 comments Download
M xfa/include/fwl/basewidget/fwl_tooltipctrl.h View 1 chunk +1 line, -4 lines 0 comments Download
M xfa/include/fwl/core/fwl_form.h View 2 chunks +1 line, -4 lines 0 comments Download
M xfa/include/fwl/core/fwl_note.h View 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/include/fwl/core/fwl_target.h View 3 chunks +2 lines, -7 lines 0 comments Download
M xfa/include/fwl/lightwidget/widget.h View 2 chunks +2 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_barcodeimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_caretimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_checkboximp.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp View 18 chunks +25 lines, -41 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_datetimepickerimp.cpp View 12 chunks +18 lines, -33 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_editimp.cpp View 9 chunks +10 lines, -34 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_listboximp.cpp View 7 chunks +8 lines, -21 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_monthcalendarimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pictureboximp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_pushbuttonimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_scrollbarimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_spinbuttonimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h View 2 chunks +6 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_editimp.h View 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/basewidget/include/fwl_listboximp.h View 2 chunks +5 lines, -2 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_contentimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_formimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_gridimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_noteimp.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_panelimp.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_targetimp.cpp View 2 chunks +1 line, -31 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_widgetimp.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_targetimp.h View 2 chunks +0 lines, -4 lines 0 comments Download
M xfa/src/fwl/src/lightwidget/barcode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/caret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/checkbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/combobox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/datetimepicker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/listbox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/picturebox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/pushbutton.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/scrollbar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/tooltipctrl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M xfa/src/fwl/src/lightwidget/widget.cpp View 2 chunks +2 lines, -31 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fffield.cpp View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
Lei, for review.
5 years ago (2015-12-08 17:27:50 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp File xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp (left): https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp#oldcode830 xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:830: return FALSE; @_@! https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/fwl_listboximp.cpp File xfa/src/fwl/src/basewidget/fwl_listboximp.cpp (right): https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/fwl_listboximp.cpp#newcode950 ...
5 years ago (2015-12-08 19:13:33 UTC) #3
Tom Sepez
Committed patchset #2 (id:20001) manually as 77221d4b4288ada80e34464ef4a402ea232b402b (presubmit successful).
5 years ago (2015-12-08 19:20:15 UTC) #5
Tom Sepez
5 years ago (2015-12-08 19:21:56 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp (left):

https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp:830: return FALSE;
On 2015/12/08 19:13:33, Lei Zhang wrote:
> @_@!

Yes, FALSE is a perfectly legitimate value for a pointer.

https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/fwl_listboximp.cpp (right):

https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/fwl_listboximp.cpp:950: (bVert ? &m_pVertScrollBar :
&m_pHorzScrollBar)->reset(pScrollBar);
On 2015/12/08 19:13:33, Lei Zhang wrote:
> Slightly unusual use of a ternary operator.
> 
> Ditto in fwl_editimp.cpp.

Seems fine to me (sorta).

https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
File xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h (left):

https://codereview.chromium.org/1509203002/diff/1/xfa/src/fwl/src/basewidget/...
xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h:133: protected:
On 2015/12/08 19:13:33, Lei Zhang wrote:
> Promoting these to public?

Fixed.

Powered by Google App Engine
This is Rietveld 408576698