Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: protected Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h
diff --git a/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h b/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h
index f824fa1c2f35dfc07fe14310914be7998cdaa2b9..356276829ea12fb501ffd05c46420cad3d522d71 100644
--- a/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h
+++ b/xfa/src/fwl/src/basewidget/include/fwl_comboboximp.h
@@ -6,6 +6,9 @@
#ifndef _FWL_COMBOBOX_IMP_H
#define _FWL_COMBOBOX_IMP_H
+
+#include "third_party/base/nonstd_unique_ptr.h"
+
class CFWL_WidgetImp;
class CFWL_WidgetImpProperties;
class CFWL_WidgetImpDelegate;
@@ -144,8 +147,6 @@ class CFWL_ComboBoxImp : public CFWL_WidgetImp {
void ReSetListItemAlignment();
void ProcessSelChanged(FX_BOOL bLButtonUp);
void InitProxyForm();
-
- protected:
FWL_ERR DisForm_Initialize();
void DisForm_InitComboList();
void DisForm_InitComboEdit();
@@ -160,15 +161,14 @@ class CFWL_ComboBoxImp : public CFWL_WidgetImp {
FWL_ERR DisForm_GetBBox(CFX_RectF& rect);
void DisForm_Layout();
- protected:
CFX_RectF m_rtClient;
CFX_RectF m_rtContent;
CFX_RectF m_rtBtn;
CFX_RectF m_rtList;
CFX_RectF m_rtProxy;
CFX_RectF m_rtHandler;
- IFWL_Edit* m_pEdit;
- IFWL_ListBox* m_pListBox;
+ nonstd::unique_ptr<IFWL_Edit> m_pEdit;
+ nonstd::unique_ptr<IFWL_ListBox> m_pListBox;
IFWL_Form* m_pForm;
FX_BOOL m_bLButtonDown;
FX_BOOL m_bUpFormHandler;
« no previous file with comments | « xfa/src/fwl/src/basewidget/fwl_tooltipctrlimp.cpp ('k') | xfa/src/fwl/src/basewidget/include/fwl_datetimepickerimp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698