FWL refcounts never incremented (part 1)

xfa/src/fwl/src/basewidget/fwl_comboboximp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../foxitlib.h"
 #include "../../src/core/include/fwl_threadimp.h"
 #include "../../src/core/include/fwl_appimp.h"
 #include "../core/include/fwl_targetimp.h"
 #include "../core/include/fwl_noteimp.h"
 #include "../core/include/fwl_widgetimp.h"
 #include "../core/include/fwl_panelimp.h"
 #include "../core/include/fwl_formimp.h"
 #include "../core/include/fwl_widgetmgrimp.h"
 #include "include/fwl_scrollbarimp.h"
 #include "include/fwl_editimp.h"
 #include "include/fwl_listboximp.h"
 #include "include/fwl_formproxyimp.h"
 #include "include/fwl_comboboximp.h"
-IFWL_ComboBox* IFWL_ComboBox::Create() {
-  return new IFWL_ComboBox;
-}
 IFWL_ComboBox::IFWL_ComboBox() {
 }
 FWL_ERR IFWL_ComboBox::Initialize(const CFWL_WidgetImpProperties& properties,
                                   IFWL_Widget* pOuter) {
   CFWL_ComboBoxImp* pComboBoxImpl = new CFWL_ComboBoxImp(properties, pOuter);
   SetImpl(pComboBoxImpl);
   pComboBoxImpl->SetInterface(this);
   return pComboBoxImpl->Initialize();
 }
 int32_t IFWL_ComboBox::GetCurSel() {
@@ skipping 301 matching lines @@
   }
   return CFWL_ListBoxImpDelegate::OnProcessMessage(pMessage);
 }
 void CFWL_ComboListImpDelegate::OnDropListFocusChanged(CFWL_Message* pMsg,
                                                        FX_BOOL bSet) {
   if (!bSet) {
     CFWL_MsgKillFocus* pKill = static_cast<CFWL_MsgKillFocus*>(pMsg);
     CFWL_ComboBoxImp* pOuter =
         static_cast<CFWL_ComboBoxImp*>(m_pOwner->m_pOuter->GetImpl());
     if (pKill->m_pSetFocus == m_pOwner->m_pOuter ||
-        pKill->m_pSetFocus == pOuter->m_pEdit) {
+        pKill->m_pSetFocus == pOuter->m_pEdit.get()) {
       pOuter->ShowDropList(FALSE);
     }
   }
 }
 int32_t CFWL_ComboListImpDelegate::OnDropListMouseMove(CFWL_MsgMouse* pMsg) {
   if (m_pOwner->m_rtClient.Contains(pMsg->m_fx, pMsg->m_fy)) {
     if (m_pOwner->m_bNotifyOwner) {
       m_pOwner->m_bNotifyOwner = FALSE;
     }
     if (m_pOwner->IsShowScrollBar(TRUE) && m_pOwner->m_pVertScrollBar) {
@@ skipping 109 matching lines @@
       rtInvalidate.Set(0, 0, m_pOwner->m_pProperties->m_rtWidget.width,
                        m_pOwner->m_pProperties->m_rtWidget.height);
       m_pOwner->Repaint(&rtInvalidate);
       break;
     }
     default: {}
   }
 }
 CFWL_ComboBoxImp::CFWL_ComboBoxImp(IFWL_Widget* pOuter)
     : CFWL_WidgetImp(pOuter),
-      m_pEdit(NULL),
-      m_pListBox(NULL),
       m_pForm(NULL),
       m_bLButtonDown(FALSE),
       m_iCurSel(-1),
       m_iBtnState(FWL_PARTSTATE_CMB_Normal),
       m_fComboFormHandler(0),
       m_bNeedShowList(FALSE) {
   m_rtClient.Reset();
   m_rtBtn.Reset();
   m_rtHandler.Reset();
 }
 CFWL_ComboBoxImp::CFWL_ComboBoxImp(const CFWL_WidgetImpProperties& properties,
                                    IFWL_Widget* pOuter)
     : CFWL_WidgetImp(properties, pOuter),
-      m_pEdit(NULL),
-      m_pListBox(NULL),
       m_pForm(NULL),
       m_bLButtonDown(FALSE),
       m_iCurSel(-1),
       m_iBtnState(FWL_PARTSTATE_CMB_Normal),
       m_fComboFormHandler(0),
       m_bNeedShowList(FALSE) {
   m_rtClient.Reset();
   m_rtBtn.Reset();
   m_rtHandler.Reset();
 }
 CFWL_ComboBoxImp::~CFWL_ComboBoxImp() {
-  if (m_pEdit) {
-    m_pEdit->Release();
-    m_pEdit = NULL;
-  }
-  if (m_pListBox) {
-    m_pListBox->Release();
-    m_pListBox = NULL;
-  }
 }
 FWL_ERR CFWL_ComboBoxImp::GetClassName(CFX_WideString& wsClass) const {
   wsClass = FWL_CLASS_ComboBox;
   return FWL_ERR_Succeeded;
 }
 FX_DWORD CFWL_ComboBoxImp::GetClassID() const {
   return FWL_CLASSHASH_ComboBox;
 }
 FWL_ERR CFWL_ComboBoxImp::Initialize() {
   if (m_pWidgetMgr->IsFormDisabled()) {
     return DisForm_Initialize();
   }
   if (CFWL_WidgetImp::Initialize() != FWL_ERR_Succeeded)
     return FWL_WGTSTATE_Invisible;  // Probably a bug; not a FWL_ERR_ value.
   m_pDelegate = new CFWL_ComboBoxImpDelegate(this);
   CFWL_WidgetImpProperties prop;
   prop.m_pThemeProvider = m_pProperties->m_pThemeProvider;
   prop.m_dwStyles |= FWL_WGTSTYLE_Border | FWL_WGTSTYLE_VScroll;
   if (m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CMB_ListItemIconText) {
     prop.m_dwStyleExes |= FWL_STYLEEXT_LTB_Icon;
   }
   prop.m_pDataProvider = m_pProperties->m_pDataProvider;
   CFWL_ComboListImp* pList = new CFWL_ComboListImp(prop, m_pInterface);
-  m_pListBox = IFWL_ListBox::Create();
-  pList->SetInterface(m_pListBox);
+  m_pListBox.reset(new IFWL_ListBox);
+  pList->SetInterface(m_pListBox.get());
   m_pListBox->SetImpl(pList);
   pList->Initialize();
   if ((m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CMB_DropDown) && !m_pEdit) {
     CFWL_ComboEditImp* pEdit = new CFWL_ComboEditImp(m_pInterface);
-    m_pEdit = IFWL_Edit::Create();
-    pEdit->SetInterface(m_pEdit);
+    m_pEdit.reset(new IFWL_Edit);
+    pEdit->SetInterface(m_pEdit.get());
     m_pEdit->SetImpl(pEdit);
     pEdit->Initialize();
     pEdit->SetOuter(m_pInterface);
   }
   if (m_pEdit) {
     m_pEdit->SetParent(m_pInterface);
   }
   SetStates(m_pProperties->m_dwStates);
   return FWL_ERR_Succeeded;
 }
@@ skipping 32 matching lines @@
 }
 FWL_ERR CFWL_ComboBoxImp::ModifyStylesEx(FX_DWORD dwStylesExAdded,
                                          FX_DWORD dwStylesExRemoved) {
   if (m_pWidgetMgr->IsFormDisabled()) {
     return DisForm_ModifyStylesEx(dwStylesExAdded, dwStylesExRemoved);
   }
   FX_BOOL bAddDropDown = dwStylesExAdded & FWL_STYLEEXT_CMB_DropDown;
   FX_BOOL bRemoveDropDown = dwStylesExRemoved & FWL_STYLEEXT_CMB_DropDown;
   if (bAddDropDown && !m_pEdit) {
     CFWL_ComboEditImp* pEdit = new CFWL_ComboEditImp(m_pInterface);
-    m_pEdit = IFWL_Edit::Create();
-    pEdit->SetInterface(m_pEdit);
+    m_pEdit.reset(new IFWL_Edit);
+    pEdit->SetInterface(m_pEdit.get());
     m_pEdit->SetImpl(pEdit);
     pEdit->Initialize();
     pEdit->SetOuter(m_pInterface);
     m_pEdit->SetParent(m_pInterface);
   } else if (bRemoveDropDown && m_pEdit) {
     m_pEdit->SetStates(FWL_WGTSTATE_Invisible, TRUE);
   }
   return CFWL_WidgetImp::ModifyStylesEx(dwStylesExAdded, dwStylesExRemoved);
 }
 FWL_ERR CFWL_ComboBoxImp::Update() {
@@ skipping 50 matching lines @@
     param.m_iPart = FWL_PART_CMB_Background;
     param.m_pGraphics = pGraphics;
     if (pMatrix) {
       param.m_matrix.Concat(*pMatrix);
     }
     param.m_rtPart = rtTextBk;
     if (m_iCurSel >= 0) {
       IFWL_ListBoxDP* pData = static_cast<IFWL_ListBoxDP*>(
           static_cast<CFWL_ComboListImp*>(m_pListBox->GetImpl())
               ->m_pProperties->m_pDataProvider);
-      void* p =
-          pData->GetItemData(m_pListBox, pData->GetItem(m_pListBox, m_iCurSel));
+      void* p = pData->GetItemData(m_pListBox.get(),
+                                   pData->GetItem(m_pListBox.get(), m_iCurSel));
       if (p != NULL) {
         param.m_pData = p;
       }
     }
     if (m_pProperties->m_dwStates & FWL_WGTSTATE_Disabled) {
       param.m_dwStates = FWL_PARTSTATE_CMB_Disabled;
     } else if ((m_pProperties->m_dwStates & FWL_WGTSTATE_Focused) &&
                (m_iCurSel >= 0)) {
       param.m_dwStates = FWL_PARTSTATE_CMB_Selected;
     } else {
@@ skipping 36 matching lines @@
     param.m_matrix.Concat(*pMatrix);
     param.m_rtPart = m_rtBtn;
     pTheme->DrawBackground(&param);
   }
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_ComboBoxImp::SetThemeProvider(IFWL_ThemeProvider* pThemeProvider) {
   if (!pThemeProvider)
     return FWL_ERR_Indefinite;
   m_pProperties->m_pThemeProvider = pThemeProvider;
-  if (m_pListBox && pThemeProvider->IsValidWidget(m_pListBox)) {
+  if (m_pListBox && pThemeProvider->IsValidWidget(m_pListBox.get())) {
     m_pListBox->SetThemeProvider(pThemeProvider);
   }
-  if (m_pEdit && pThemeProvider->IsValidWidget(m_pEdit)) {
+  if (m_pEdit && pThemeProvider->IsValidWidget(m_pEdit.get())) {
     m_pEdit->SetThemeProvider(pThemeProvider);
   }
   return FWL_ERR_Succeeded;
 }
 int32_t CFWL_ComboBoxImp::GetCurSel() {
   return m_iCurSel;
 }
 FWL_ERR CFWL_ComboBoxImp::SetCurSel(int32_t iSel) {
   int32_t iCount =
       static_cast<CFWL_ComboListImp*>(m_pListBox->GetImpl())->CountItems();
@@ skipping 81 matching lines @@
   if (!m_pEdit)
     return FALSE;
   return m_pEdit->Redo(bsRecord);
 }
 FX_BOOL CFWL_ComboBoxImp::EditUndo(const CFX_ByteStringC& bsRecord) {
   if (!m_pEdit)
     return FALSE;
   return m_pEdit->Undo(bsRecord);
 }
 IFWL_ListBox* CFWL_ComboBoxImp::GetListBoxt() {
-  if (!m_pListBox)
-    return FALSE;
-  return m_pListBox;
+  return m_pListBox.get();
 }
 FX_BOOL CFWL_ComboBoxImp::AfterFocusShowDropList() {
   if (!m_bNeedShowList) {
     return FALSE;
   }
   if (m_pEdit) {
     MatchEditText();
   }
   ShowDropList(TRUE);
   m_bNeedShowList = FALSE;
@@ skipping 223 matching lines @@
     m_pEdit->Update();
   }
 }
 void CFWL_ComboBoxImp::ReSetTheme() {
   IFWL_ThemeProvider* pTheme = m_pProperties->m_pThemeProvider;
   if (!pTheme) {
     pTheme = GetAvailableTheme();
     m_pProperties->m_pThemeProvider = pTheme;
   }
   if (m_pListBox) {
-    if (!m_pListBox->GetThemeProvider() && pTheme->IsValidWidget(m_pListBox)) {
+    if (!m_pListBox->GetThemeProvider() &&
+        pTheme->IsValidWidget(m_pListBox.get())) {
       m_pListBox->SetThemeProvider(pTheme);
     }
   }
   if (m_pEdit) {
-    if (!m_pEdit->GetThemeProvider() && pTheme->IsValidWidget(m_pEdit)) {
+    if (!m_pEdit->GetThemeProvider() && pTheme->IsValidWidget(m_pEdit.get())) {
       m_pEdit->SetThemeProvider(pTheme);
     }
   }
 }
 void CFWL_ComboBoxImp::ReSetEditAlignment() {
   if (!m_pEdit)
     return;
   FX_DWORD dwStylExes = m_pProperties->m_dwStyleExes;
   FX_DWORD dwAdd = 0;
   switch (dwStylExes & FWL_STYLEEXT_CMB_EditHAlignMask) {
@@ skipping 73 matching lines @@
 }
 void CFWL_ComboBoxImp::InitProxyForm() {
   if (m_pForm)
     return;
   if (!m_pListBox)
     return;
   CFWL_WidgetImpProperties propForm;
   propForm.m_pOwner = m_pInterface;
   propForm.m_dwStyles = FWL_WGTSTYLE_Popup;
   propForm.m_dwStates = FWL_WGTSTATE_Invisible;
-  m_pProxy = new CFWL_FormProxyImp(propForm, m_pListBox);
-  m_pForm = IFWL_Form::Create();
+  m_pProxy = new CFWL_FormProxyImp(propForm, m_pListBox.get());
+  m_pForm = new IFWL_Form;
   m_pProxy->SetInterface(m_pForm);
   m_pForm->SetImpl(m_pProxy);
   m_pProxy->Initialize();
   m_pListBox->SetParent(m_pForm);
   m_pListProxyDelegate = new CFWL_ComboProxyImpDelegate(m_pForm, this);
   m_pProxy->SetDelegate(m_pListProxyDelegate);
 }
 FWL_ERR CFWL_ComboBoxImp::DisForm_Initialize() {
   if (CFWL_WidgetImp::Initialize() != FWL_ERR_Succeeded)
     return FWL_WGTSTATE_Invisible;  // Ditto.
   m_pDelegate = new CFWL_ComboBoxImpDelegate(this);
   DisForm_InitComboList();
   DisForm_InitComboEdit();
   return FWL_ERR_Succeeded;
 }
 void CFWL_ComboBoxImp::DisForm_InitComboList() {
   if (m_pListBox) {
     return;
   }
   CFWL_WidgetImpProperties prop;
   prop.m_pParent = m_pInterface;
   prop.m_dwStyles = FWL_WGTSTYLE_Border | FWL_WGTSTYLE_VScroll;
   prop.m_dwStates = FWL_WGTSTATE_Invisible;
   prop.m_pDataProvider = m_pProperties->m_pDataProvider;
   prop.m_pThemeProvider = m_pProperties->m_pThemeProvider;
   CFWL_ComboListImp* pList = new CFWL_ComboListImp(prop, m_pInterface);
-  m_pListBox = IFWL_ListBox::Create();
-  pList->SetInterface(m_pListBox);
+  m_pListBox.reset(new IFWL_ListBox);
+  pList->SetInterface(m_pListBox.get());
   m_pListBox->SetImpl(pList);
   pList->Initialize();
 }
 void CFWL_ComboBoxImp::DisForm_InitComboEdit() {
   if (m_pEdit) {
     return;
   }
   CFWL_WidgetImpProperties prop;
   prop.m_pParent = m_pInterface;
   prop.m_pThemeProvider = m_pProperties->m_pThemeProvider;
   if ((m_pProperties->m_dwStyleExes & FWL_STYLEEXT_CMB_DropDown) == 0) {
   }
   CFWL_ComboEditImp* pEdit = new CFWL_ComboEditImp(prop, m_pInterface);
-  m_pEdit = IFWL_Edit::Create();
-  pEdit->SetInterface(m_pEdit);
+  m_pEdit.reset(new IFWL_Edit);
+  pEdit->SetInterface(m_pEdit.get());
   m_pEdit->SetImpl(pEdit);
   pEdit->Initialize();
   pEdit->SetOuter(m_pInterface);
 }
 void CFWL_ComboBoxImp::DisForm_ShowDropList(FX_BOOL bActivate) {
   FX_BOOL bDropList = DisForm_IsDropListShowed();
   if (bDropList == bActivate) {
     return;
   }
   if (bActivate) {
@@ skipping 257 matching lines @@
                                                const CFX_Matrix* pMatrix) {
   return m_pOwner->DrawWidget(pGraphics, pMatrix);
 }
 void CFWL_ComboBoxImpDelegate::OnFocusChanged(CFWL_Message* pMsg,
                                               FX_BOOL bSet) {
   IFWL_Target* pDstTarget = pMsg->m_pDstTarget;
   IFWL_Target* pSrcTarget = pMsg->m_pSrcTarget;
   FX_BOOL bDropDown = m_pOwner->IsDropDownStyle();
   if (bSet) {
     m_pOwner->m_pProperties->m_dwStates |= FWL_WGTSTATE_Focused;
-    if (bDropDown && pSrcTarget != m_pOwner->m_pListBox) {
+    if (bDropDown && pSrcTarget != m_pOwner->m_pListBox.get()) {
       if (!m_pOwner->m_pEdit)
         return;
       static_cast<CFWL_ComboEditImp*>(m_pOwner->m_pEdit->GetImpl())
           ->SetSelected();
     } else {
       m_pOwner->Repaint(&m_pOwner->m_rtClient);
     }
   } else {
     m_pOwner->m_pProperties->m_dwStates &= ~FWL_WGTSTATE_Focused;
-    if (bDropDown && pDstTarget != m_pOwner->m_pListBox) {
+    if (bDropDown && pDstTarget != m_pOwner->m_pListBox.get()) {
       if (!m_pOwner->m_pEdit)
         return;
       static_cast<CFWL_ComboEditImp*>(m_pOwner->m_pEdit->GetImpl())
           ->FlagFocus(FALSE);
       static_cast<CFWL_ComboEditImp*>(m_pOwner->m_pEdit->GetImpl())
           ->ClearSelected();
     } else {
       m_pOwner->Repaint(&m_pOwner->m_rtClient);
     }
   }
@@ skipping 189 matching lines @@
       m_pOwner->DisForm_ShowDropList(TRUE);
     }
   }
 }
 void CFWL_ComboBoxImpDelegate::DisForm_OnFocusChanged(CFWL_Message* pMsg,
                                                       FX_BOOL bSet) {
   if (bSet) {
     m_pOwner->m_pProperties->m_dwStates |= FWL_WGTSTATE_Focused;
     if ((m_pOwner->m_pEdit->GetStates() & FWL_WGTSTATE_Focused) == 0) {
       CFWL_MsgSetFocus msg;
-      msg.m_pDstTarget = m_pOwner->m_pEdit;
+      msg.m_pDstTarget = m_pOwner->m_pEdit.get();
       msg.m_pSrcTarget = NULL;
       IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
       pDelegate->OnProcessMessage(&msg);
     }
   } else {
     m_pOwner->m_pProperties->m_dwStates &= ~FWL_WGTSTATE_Focused;
     m_pOwner->DisForm_ShowDropList(FALSE);
     CFWL_MsgKillFocus msg;
     msg.m_pDstTarget = NULL;
-    msg.m_pSrcTarget = m_pOwner->m_pEdit;
+    msg.m_pSrcTarget = m_pOwner->m_pEdit.get();
     IFWL_WidgetDelegate* pDelegate = m_pOwner->m_pEdit->SetDelegate(NULL);
     pDelegate->OnProcessMessage(&msg);
   }
 }
 void CFWL_ComboBoxImpDelegate::DisForm_OnKey(CFWL_MsgKey* pMsg) {
   FX_DWORD dwKeyCode = pMsg->m_dwKeyCode;
   FX_BOOL bUp = dwKeyCode == FWL_VKEY_Up;
   FX_BOOL bDown = dwKeyCode == FWL_VKEY_Down;
   if (bUp || bDown) {
     CFWL_ComboListImp* pComboList =
@@ skipping 169 matching lines @@
   m_pComboBox->ShowDropList(FALSE);
 }
 void CFWL_ComboProxyImpDelegate::OnFocusChanged(CFWL_MsgKillFocus* pMsg,
                                                 FX_BOOL bSet) {
   if (!bSet) {
     if (pMsg->m_pSetFocus == NULL) {
       m_pComboBox->ShowDropList(FALSE);
     }
   }
 }