Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: xfa/src/fwl/src/core/fwl_targetimp.cpp

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: protected Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fwl/src/core/fwl_panelimp.cpp ('k') | xfa/src/fwl/src/core/fwl_widgetimp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fwl/src/core/fwl_targetimp.cpp
diff --git a/xfa/src/fwl/src/core/fwl_targetimp.cpp b/xfa/src/fwl/src/core/fwl_targetimp.cpp
index 0ae40d11f47ca845ceb52dd8c2e99ea159e9c95f..dde102159b55af93bdd060f7de4a32330209889f 100644
--- a/xfa/src/fwl/src/core/fwl_targetimp.cpp
+++ b/xfa/src/fwl/src/core/fwl_targetimp.cpp
@@ -6,20 +6,6 @@
#include "../../../foxitlib.h"
#include "include/fwl_targetimp.h"
-FX_DWORD IFWL_Target::Release() {
- FX_DWORD dwRef = m_pImpl->Release();
- if (!dwRef) {
- m_pImpl = nullptr;
- delete this;
- }
- return dwRef;
-}
-IFWL_Target* IFWL_Target::Retain() {
- return m_pImpl->Retain();
-}
-FX_DWORD IFWL_Target::GetRefCount() const {
- return m_pImpl->GetRefCount();
-}
FWL_ERR IFWL_Target::GetClassName(CFX_WideString& wsClass) const {
return m_pImpl->GetClassName(wsClass);
}
@@ -38,25 +24,9 @@ FWL_ERR IFWL_Target::Finalize() {
IFWL_Target::~IFWL_Target() {
delete m_pImpl;
}
-CFWL_TargetImp::CFWL_TargetImp() : m_dwRefCount(1) {
-}
+CFWL_TargetImp::CFWL_TargetImp() {}
CFWL_TargetImp::~CFWL_TargetImp() {
}
-FX_DWORD CFWL_TargetImp::Release() {
- m_dwRefCount--;
- FX_DWORD dwRet = m_dwRefCount;
- if (!m_dwRefCount) {
- delete this;
- }
- return dwRet;
-}
-IFWL_Target* CFWL_TargetImp::Retain() {
- m_dwRefCount++;
- return (IFWL_Target*)this;
-}
-FX_DWORD CFWL_TargetImp::GetRefCount() const {
- return m_dwRefCount;
-}
FWL_ERR CFWL_TargetImp::GetClassName(CFX_WideString& wsClass) const {
return FWL_ERR_Succeeded;
}
« no previous file with comments | « xfa/src/fwl/src/core/fwl_panelimp.cpp ('k') | xfa/src/fwl/src/core/fwl_widgetimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698