xfa/src/fwl/src/core/include/fwl_targetimp.h - Issue 1509203002: FWL refcounts never incremented (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/core/include/fwl_targetimp.h

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: protected Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/core/include/fwl_targetimp.h

diff --git a/xfa/src/fwl/src/core/include/fwl_targetimp.h b/xfa/src/fwl/src/core/include/fwl_targetimp.h

index 5f494a78e2d4fd6c3b422d15552b5953b3b265a8..d0a6caa30822f71b7d030c67591b23b85b281899 100644

--- a/xfa/src/fwl/src/core/include/fwl_targetimp.h

+++ b/xfa/src/fwl/src/core/include/fwl_targetimp.h

@@ -14,9 +14,6 @@ class CFWL_TargetImp {

public:

virtual ~CFWL_TargetImp();

- virtual FX_DWORD Release();

- virtual IFWL_Target* Retain();

- virtual FX_DWORD GetRefCount() const;

virtual FWL_ERR GetClassName(CFX_WideString& wsClass) const;

virtual FX_DWORD GetClassID() const;

virtual FX_BOOL IsInstance(const CFX_WideStringC& wsClass) const;

@@ -25,7 +22,6 @@ class CFWL_TargetImp {

protected:

CFWL_TargetImp();

- FX_DWORD m_dwRefCount;

};

#endif // FWL_TARGETIMP_H_

« no previous file with comments | « xfa/src/fwl/src/core/fwl_widgetimp.cpp ('k') | xfa/src/fwl/src/lightwidget/barcode.cpp » ('j') | no next file with comments »