Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Unified Diff: xfa/src/fwl/src/core/fwl_noteimp.cpp

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: protected Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « xfa/src/fwl/src/core/fwl_gridimp.cpp ('k') | xfa/src/fwl/src/core/fwl_panelimp.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/src/fwl/src/core/fwl_noteimp.cpp
diff --git a/xfa/src/fwl/src/core/fwl_noteimp.cpp b/xfa/src/fwl/src/core/fwl_noteimp.cpp
index 149b80f26ca1f2b4438a0ceeafd1b656b6f53ee6..4bc28b87ddab05f0d873ba8800be9e1259889d79 100644
--- a/xfa/src/fwl/src/core/fwl_noteimp.cpp
+++ b/xfa/src/fwl/src/core/fwl_noteimp.cpp
@@ -937,13 +937,9 @@ CFWL_ToolTipContainer::~CFWL_ToolTipContainer() {
if (m_pToolTipImp) {
IFWL_ToolTip* pToolTip = (IFWL_ToolTip*)m_pToolTipImp->GetInterface();
pToolTip->Finalize();
- pToolTip->Release();
- m_pToolTipImp = NULL;
- }
- if (m_ToolTipDp) {
- delete m_ToolTipDp;
- m_ToolTipDp = NULL;
+ delete pToolTip;
}
+ delete m_ToolTipDp;
}
// static
CFWL_ToolTipContainer* CFWL_ToolTipContainer::getInstance() {
@@ -996,7 +992,7 @@ FX_BOOL CFWL_ToolTipContainer::ProcessEnter(CFWL_EvtMouse* pEvt,
rtTooltip.Set(150, 150, 100, 50);
prop.m_rtWidget = rtTooltip;
m_pToolTipImp = new CFWL_ToolTipImp(prop);
- IFWL_ToolTip* pToolTip = IFWL_ToolTip::Create();
+ IFWL_ToolTip* pToolTip = new IFWL_ToolTip;
m_pToolTipImp->SetInterface(pToolTip);
pToolTip->SetImpl(m_pToolTipImp);
m_pToolTipImp->Initialize();
« no previous file with comments | « xfa/src/fwl/src/core/fwl_gridimp.cpp ('k') | xfa/src/fwl/src/core/fwl_panelimp.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698