xfa/src/fwl/src/lightwidget/pushbutton.cpp - Issue 1509203002: FWL refcounts never incremented (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/lightwidget/pushbutton.cpp

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: protected Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/lightwidget/pushbutton.cpp

diff --git a/xfa/src/fwl/src/lightwidget/pushbutton.cpp b/xfa/src/fwl/src/lightwidget/pushbutton.cpp

index 28a7fa5d333bbdeb096eeb5dca18df3548c0df8c..24050c86662a8ab7913c830d4c9655a51b9f400f 100644

--- a/xfa/src/fwl/src/lightwidget/pushbutton.cpp

+++ b/xfa/src/fwl/src/lightwidget/pushbutton.cpp

@@ -14,7 +14,7 @@ FWL_ERR CFWL_PushButton::Initialize(const CFWL_WidgetProperties* pProperties) {

if (pProperties) {

*m_pProperties = *pProperties;

}

- m_pIface = IFWL_PushButton::Create();

+ m_pIface = new IFWL_PushButton;

FWL_ERR ret =

((IFWL_PushButton*)m_pIface)

->Initialize(m_pProperties->MakeWidgetImpProperties(&m_buttonData),