xfa/src/fwl/src/basewidget/fwl_caretimp.cpp - Issue 1509203002: FWL refcounts never incremented (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: protected Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

diff --git a/xfa/src/fwl/src/basewidget/fwl_caretimp.cpp b/xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

index 98bcbb59e29303615d610aac8408132d27f81be8..24104e19b5b3d9dcdb2a39ab0d0f378707dd8201 100644

--- a/xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

+++ b/xfa/src/fwl/src/basewidget/fwl_caretimp.cpp

@@ -9,9 +9,6 @@

#include "../core/include/fwl_noteimp.h"

#include "../core/include/fwl_widgetimp.h"

#include "include/fwl_caretimp.h"

-IFWL_Caret* IFWL_Caret::Create() {

- return new IFWL_Caret;

IFWL_Caret::IFWL_Caret() {

}

FWL_ERR IFWL_Caret::Initialize(IFWL_Widget* pOuter) {