xfa/include/fwl/basewidget/fwl_scrollbar.h - Issue 1509203002: FWL refcounts never incremented (part 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/include/fwl/basewidget/fwl_scrollbar.h

Issue 1509203002: FWL refcounts never incremented (part 1) (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: protected Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/include/fwl/basewidget/fwl_scrollbar.h

diff --git a/xfa/include/fwl/basewidget/fwl_scrollbar.h b/xfa/include/fwl/basewidget/fwl_scrollbar.h

index 1dd7dd2d5c878251c884af1c8375b361a5132782..10ce5f2688302ba4f32bbcd06ecc55ab67c5284e 100644

--- a/xfa/include/fwl/basewidget/fwl_scrollbar.h

+++ b/xfa/include/fwl/basewidget/fwl_scrollbar.h

@@ -47,7 +47,7 @@ enum FWL_SCBCODE {

class IFWL_ScrollBarDP : public IFWL_DataProvider {};

class IFWL_ScrollBar : public IFWL_Widget {

public:

- static IFWL_ScrollBar* Create();

+ IFWL_ScrollBar();

FWL_ERR Initialize(const CFWL_WidgetImpProperties& properties,

IFWL_Widget* pOuter);

FX_BOOL IsVertical();

@@ -62,8 +62,5 @@ class IFWL_ScrollBar : public IFWL_Widget {

FX_FLOAT GetTrackPos();

FWL_ERR SetTrackPos(FX_FLOAT fTrackPos);

FX_BOOL DoScroll(FX_DWORD dwCode, FX_FLOAT fPos = 0.0f);

- protected:

- IFWL_ScrollBar();

};

#endif