Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(479)

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, sadrul, vmpstr+watch_chromium.org, tfarina, gavinp+memory_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org, tracing+reviews_chromium.org, chirantan+watch_chromium.org, piman, Mark Mentovai
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Use std::move() instead of Pass() for real movable types. Some of our movable types have real move-constructors/assignment operators now. We can use std::move() for these types instead of Pass(). There's still some move-only types that are implemented using an "Rvalue" type emulation, so we have to keep Pass() for those still. R=thestig@chromium.org BUG=557422 Committed: https://crrev.com/0c8d4aa8ba54f463cc22ce21bf1088edd3d1e207 Cr-Commit-Position: refs/heads/master@{#361583}

Patch Set 1 #

Total comments: 4

Patch Set 2 : basepass: missing-include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -287 lines) Patch
M base/containers/scoped_ptr_hash_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/containers/scoped_ptr_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/containers/scoped_ptr_map_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/environment_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/feature_list_unittest.cc View 7 chunks +8 lines, -6 lines 0 comments Download
M base/files/file_path_watcher.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/files/important_file_writer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/files/memory_mapped_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_writer_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/memory/ref_counted.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/memory/ref_counted_unittest.cc View 9 chunks +8 lines, -28 lines 0 comments Download
M base/memory/scoped_ptr.h View 1 chunk +17 lines, -16 lines 0 comments Download
M base/memory/scoped_ptr_unittest.cc View 16 chunks +30 lines, -27 lines 0 comments Download
M base/memory/shared_memory_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 5 chunks +5 lines, -10 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/message_loop/message_loop.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/message_loop/message_loop_test.cc View 25 chunks +26 lines, -24 lines 0 comments Download
M base/metrics/histogram.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/histogram_base.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M base/metrics/sparse_histogram.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/move_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/power_monitor/power_monitor.cc View 2 chunks +4 lines, -1 line 0 comments Download
M base/prefs/default_pref_store.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M base/prefs/json_pref_store.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M base/prefs/json_pref_store_unittest.cc View 5 chunks +11 lines, -7 lines 0 comments Download
M base/prefs/overlay_user_pref_store.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M base/prefs/pref_member.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/prefs/pref_service.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M base/prefs/pref_service_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/prefs/pref_value_map.cc View 2 chunks +2 lines, -1 line 0 comments Download
M base/prefs/testing_pref_store.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/prefs/value_map_pref_store.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M base/process/process_metrics.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M base/process/process_metrics_linux.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M base/profiler/stack_sampling_profiler.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M base/profiler/win32_stack_frame_unwinder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/profiler/win32_stack_frame_unwinder_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M base/scoped_generic_unittest.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M base/sequence_checker_unittest.cc View 6 chunks +8 lines, -5 lines 0 comments Download
M base/task_runner_util_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/test/histogram_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/test/launcher/test_results_tracker.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M base/test/thread_test_helper.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M base/test/values_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/timer/hi_res_timer_manager_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/trace_event/memory_dump_manager.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M base/trace_event/trace_buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M base/trace_event/trace_config.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M base/trace_event/trace_event_argument.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/trace_event/trace_event_argument_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M base/trace_event/trace_event_memory.cc View 2 chunks +3 lines, -1 line 0 comments Download
M base/trace_event/trace_log.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M base/values.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M base/values_unittest.cc View 14 chunks +39 lines, -38 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (7 generated)
danakj
4 years, 8 months ago (2015-11-25 00:18:12 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1479473002/diff/1/base/process/process_metrics.cc File base/process/process_metrics.cc (right): https://codereview.chromium.org/1479473002/diff/1/base/process/process_metrics.cc#newcode43 base/process/process_metrics.cc:43: return std::move(res); #include <utility> ? You've been mostly ...
4 years, 8 months ago (2015-11-25 00:55:04 UTC) #5
danakj
https://codereview.chromium.org/1479473002/diff/1/base/process/process_metrics.cc File base/process/process_metrics.cc (right): https://codereview.chromium.org/1479473002/diff/1/base/process/process_metrics.cc#newcode43 base/process/process_metrics.cc:43: return std::move(res); On 2015/11/25 00:55:04, Lei Zhang wrote: > ...
4 years, 8 months ago (2015-11-25 01:01:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479473002/20001
4 years, 8 months ago (2015-11-25 01:07:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/101048)
4 years, 8 months ago (2015-11-25 03:45:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1479473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1479473002/20001
4 years, 8 months ago (2015-11-25 03:56:49 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2015-11-25 05:30:06 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2015-11-25 05:31:04 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0c8d4aa8ba54f463cc22ce21bf1088edd3d1e207
Cr-Commit-Position: refs/heads/master@{#361583}

Powered by Google App Engine
This is Rietveld 408576698