Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: base/test/thread_test_helper.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/test/launcher/test_results_tracker.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/thread_test_helper.h" 5 #include "base/test/thread_test_helper.h"
6 6
7 #include <utility>
8
7 #include "base/bind.h" 9 #include "base/bind.h"
8 #include "base/location.h" 10 #include "base/location.h"
9 #include "base/threading/thread_restrictions.h" 11 #include "base/threading/thread_restrictions.h"
10 12
11 namespace base { 13 namespace base {
12 14
13 ThreadTestHelper::ThreadTestHelper( 15 ThreadTestHelper::ThreadTestHelper(
14 scoped_refptr<SingleThreadTaskRunner> target_thread) 16 scoped_refptr<SingleThreadTaskRunner> target_thread)
15 : test_result_(false), 17 : test_result_(false),
16 target_thread_(target_thread.Pass()), 18 target_thread_(std::move(target_thread)),
17 done_event_(false, false) { 19 done_event_(false, false) {}
18 }
19 20
20 bool ThreadTestHelper::Run() { 21 bool ThreadTestHelper::Run() {
21 if (!target_thread_->PostTask( 22 if (!target_thread_->PostTask(
22 FROM_HERE, base::Bind(&ThreadTestHelper::RunInThread, this))) { 23 FROM_HERE, base::Bind(&ThreadTestHelper::RunInThread, this))) {
23 return false; 24 return false;
24 } 25 }
25 base::ThreadRestrictions::ScopedAllowWait allow_wait; 26 base::ThreadRestrictions::ScopedAllowWait allow_wait;
26 done_event_.Wait(); 27 done_event_.Wait();
27 return test_result_; 28 return test_result_;
28 } 29 }
29 30
30 void ThreadTestHelper::RunTest() { set_test_result(true); } 31 void ThreadTestHelper::RunTest() { set_test_result(true); }
31 32
32 ThreadTestHelper::~ThreadTestHelper() {} 33 ThreadTestHelper::~ThreadTestHelper() {}
33 34
34 void ThreadTestHelper::RunInThread() { 35 void ThreadTestHelper::RunInThread() {
35 RunTest(); 36 RunTest();
36 done_event_.Signal(); 37 done_event_.Signal();
37 } 38 }
38 39
39 } // namespace base 40 } // namespace base
OLDNEW
« no previous file with comments | « base/test/launcher/test_results_tracker.cc ('k') | base/test/values_test_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698