Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4147)

Unified Diff: base/memory/shared_memory_mac_unittest.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/memory/shared_memory_mac.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/shared_memory_mac_unittest.cc
diff --git a/base/memory/shared_memory_mac_unittest.cc b/base/memory/shared_memory_mac_unittest.cc
index fcc38bff38b15b30a8be6196e7dceb253cc92860..1c918341a9af9f859e35f1b49c235cff8a0d50a7 100644
--- a/base/memory/shared_memory_mac_unittest.cc
+++ b/base/memory/shared_memory_mac_unittest.cc
@@ -231,8 +231,7 @@ TEST_F(SharedMemoryMacMultiProcessTest, MachBasedSharedMemory) {
SetUpChild("MachBasedSharedMemoryClient");
- scoped_ptr<SharedMemory> shared_memory(
- CreateSharedMemory(s_memory_size).Pass());
+ scoped_ptr<SharedMemory> shared_memory(CreateSharedMemory(s_memory_size));
// Send the underlying memory object to the client process.
SendMachPort(client_port_.get(), shared_memory->handle().GetMemoryObject(),
@@ -383,8 +382,7 @@ TEST_F(SharedMemoryMacMultiProcessTest, MachReadOnly) {
if (mac::IsOSSnowLeopard())
return;
- scoped_ptr<SharedMemory> shared_memory(
- CreateSharedMemory(s_memory_size).Pass());
+ scoped_ptr<SharedMemory> shared_memory(CreateSharedMemory(s_memory_size));
SharedMemoryHandle shm2 = shared_memory->handle().Duplicate();
ASSERT_TRUE(shm2.IsValid());
@@ -402,8 +400,7 @@ TEST_F(SharedMemoryMacMultiProcessTest, MachShareToProcess) {
mach_msg_type_number_t active_name_count = GetActiveNameCount();
{
- scoped_ptr<SharedMemory> shared_memory(
- CreateSharedMemory(s_memory_size).Pass());
+ scoped_ptr<SharedMemory> shared_memory(CreateSharedMemory(s_memory_size));
SharedMemoryHandle shm2;
ASSERT_TRUE(shared_memory->ShareToProcess(GetCurrentProcId(), &shm2));
@@ -425,8 +422,7 @@ TEST_F(SharedMemoryMacMultiProcessTest, MachShareToProcessReadonly) {
if (mac::IsOSSnowLeopard())
return;
- scoped_ptr<SharedMemory> shared_memory(
- CreateSharedMemory(s_memory_size).Pass());
+ scoped_ptr<SharedMemory> shared_memory(CreateSharedMemory(s_memory_size));
// Check the protection levels.
int current_prot, max_prot;
@@ -472,8 +468,7 @@ TEST_F(SharedMemoryMacMultiProcessTest, MachShareToProcessReadonlyLeak) {
mach_msg_type_number_t active_name_count = GetActiveNameCount();
{
- scoped_ptr<SharedMemory> shared_memory(
- CreateSharedMemory(s_memory_size).Pass());
+ scoped_ptr<SharedMemory> shared_memory(CreateSharedMemory(s_memory_size));
SharedMemoryHandle shm2;
ASSERT_TRUE(
« no previous file with comments | « base/memory/shared_memory_mac.cc ('k') | base/memory/shared_memory_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698