Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: base/move_unittest.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/sparse_histogram.cc ('k') | base/power_monitor/power_monitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/move_unittest.cc
diff --git a/base/move_unittest.cc b/base/move_unittest.cc
index 1f4ce84cb6af4f1aac736704b271fea1b6fc4b19..da0be638c5ba26734ac0de3e39fc516afee57bba 100644
--- a/base/move_unittest.cc
+++ b/base/move_unittest.cc
@@ -24,7 +24,7 @@ class Container {
Container(const Container& other) = default;
Container& operator=(const Container& other) = default;
- Container(Container&& other) { value_ = other.value_.Pass(); }
+ Container(Container&& other) { value_ = std::move(other.value_); }
Container& operator=(Container&& other) {
value_ = other.value_.Pass();
« no previous file with comments | « base/metrics/sparse_histogram.cc ('k') | base/power_monitor/power_monitor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698