Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1477643002: Remove the TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro. (Closed)

Created:
5 years ago by danakj
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-worker-reviews_chromium.org, brucedawson, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, dcheng, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, hans, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, Mark Mentovai, maxbogue+watch_chromium.org, mcasas+watch_chromium.org, michaeln, miu+watch_chromium.org, nhiroki, piman, plaree+watch_chromium.org, posciak+watch_chromium.org, pvalenzuela+watch_chromium.org, qsr+mojo_chromium.org, scheduler-bugs_chromium.org, scheib+watch_chromium.org, serviceworker-reviews, Lei Zhang, tim+watch_chromium.org, tzik, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, yzshen+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@basepass
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the TYPE_WITH_MOVE_CONSTRUCTOR_FOR_CPP_03 macro. This macro existed only to add a Pass() method on scoped_refptr and skia::RefPtr. We can just use std::move() now, so replace callsites to Pass() with std::move() and kill the macro. R=thakis@chromium.org BUG=557422 Committed: https://crrev.com/4b041ab3706e1c26bf105617750353ec111cf18b Cr-Commit-Position: refs/heads/master@{#363281}

Patch Set 1 #

Patch Set 2 : type-with-move: . #

Total comments: 3

Patch Set 3 : type-with-move: move-constructors #

Patch Set 4 : type-with-move: rebase #

Patch Set 5 : type-with-move: one-more-comonents-fix #

Patch Set 6 : type-with-move: more #

Patch Set 7 : type-with-move: more-pass-call-sites #

Patch Set 8 : type-with-move: rebase #

Patch Set 9 : type-with-move: windows #

Patch Set 10 : type-with-move: more-pass-appeared #

Patch Set 11 : type-with-move: ios-pass #

Patch Set 12 : type-with-move: more-ios-pass #

Patch Set 13 : type-with-move: more-ios #

Patch Set 14 : type-with-move: no-media #

Unified diffs Side-by-side diffs Delta from patch set Stats (+173 lines, -149 lines) Patch
M base/memory/ref_counted.h View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M base/move.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/platform_keys/platform_keys_service.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/printer_detector/printer_detector_unittest.cc View 1 2 3 4 5 6 7 8 9 4 chunks +26 lines, -34 lines 0 comments Download
M components/component_updater/component_updater_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/scheduler_tqm_delegate_for_test.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M components/scheduler/child/worker_scheduler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/scheduler/test/lazy_scheduler_message_loop_delegate_for_tests.cc View 1 2 3 4 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 1 2 3 4 5 6 23 chunks +23 lines, -23 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ios/net/http_response_headers_util.mm View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cert_verifier_block_adapter.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/crw_cert_verification_controller.mm View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/handle_win.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -1 line 0 comments Download
M media/mojo/services/media_type_converters.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.cc View 1 2 3 4 5 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/bindings_serialization.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/bindings/lib/scoped_interface_endpoint_handle.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
M net/cert/ct_log_verifier_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/cert/ct_objects_extractor_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/multi_threaded_proxy_resolver.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M net/ssl/client_key_store.cc View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M net/ssl/ssl_platform_key_task_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ssl/threaded_ssl_private_key.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M skia/ext/refptr.h View 1 2 4 chunks +11 lines, -5 lines 0 comments Download
M skia/ext/refptr_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -11 lines 0 comments Download
M sync/api/entity_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/util/proto_value_ptr.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/ipc_support_unittest.cc View 1 2 3 4 5 6 4 chunks +6 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/shared_buffer_dispatcher.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/test/scoped_ipc_support.cc View 1 2 3 4 5 7 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 129 (69 generated)
danakj
thakis: please review base/ and overall change other owners.. jamesr: third_party/mojo/ sky: mojo/ ellyjones: net/ ...
5 years ago (2015-11-25 00:48:48 UTC) #9
danakj
On 2015/11/25 00:48:48, danakj (behind on reviews) wrote: > thakis: please review base/ and overall ...
5 years ago (2015-11-25 00:49:16 UTC) #10
dcheng
https://codereview.chromium.org/1477643002/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/1477643002/diff/20001/base/memory/ref_counted.h#newcode290 base/memory/ref_counted.h:290: scoped_refptr(scoped_refptr<U>&& r) : ptr_(r.get()) { Would it make sense ...
5 years ago (2015-11-25 06:28:09 UTC) #12
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-11-25 08:37:02 UTC) #13
Elly Fong-Jones
net/* lgtm
5 years ago (2015-11-25 13:03:14 UTC) #14
Nico
lgtm with dcheng's comment addressed. Thanks! https://codereview.chromium.org/1477643002/diff/20001/skia/ext/refptr.h File skia/ext/refptr.h (right): https://codereview.chromium.org/1477643002/diff/20001/skia/ext/refptr.h#newcode71 skia/ext/refptr.h:71: RefPtr(RefPtr<U>&& other) I ...
5 years ago (2015-11-25 14:53:45 UTC) #15
sky
LGTM
5 years ago (2015-11-25 17:22:53 UTC) #16
pavely
sync/* lgtm
5 years ago (2015-11-25 18:35:42 UTC) #17
danakj
https://codereview.chromium.org/1477643002/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/1477643002/diff/20001/base/memory/ref_counted.h#newcode290 base/memory/ref_counted.h:290: scoped_refptr(scoped_refptr<U>&& r) : ptr_(r.get()) { On 2015/11/25 06:28:09, dcheng ...
5 years ago (2015-11-25 19:35:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/40001
5 years ago (2015-11-25 19:37:18 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/128157) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-11-25 19:39:58 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/60001
5 years ago (2015-11-25 19:47:14 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/80001
5 years ago (2015-11-25 19:59:01 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/149655) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-11-25 20:17:52 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/100001
5 years ago (2015-11-25 21:37:40 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/127761) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-11-25 21:55:06 UTC) #36
danakj
+xhwang@chromium.org for media/
5 years ago (2015-11-25 22:52:42 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/120001
5 years ago (2015-11-25 22:55:18 UTC) #42
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/149772) android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-11-25 22:57:49 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/140001
5 years ago (2015-11-25 23:05:22 UTC) #47
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/71869)
5 years ago (2015-11-25 23:20:52 UTC) #49
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/140001
5 years ago (2015-11-25 23:32:01 UTC) #51
xhwang
media/ lgtm
5 years ago (2015-11-25 23:35:45 UTC) #52
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/125770) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years ago (2015-11-26 00:01:07 UTC) #54
danakj
+tsepez@chromium.org for ipc/ changing Pass() to std::move().
5 years ago (2015-11-26 00:07:17 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/160001
5 years ago (2015-11-26 00:09:29 UTC) #60
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_compile_dbg_ng/builds/125813) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years ago (2015-11-26 01:07:39 UTC) #62
Tom Sepez
On 2015/11/26 00:07:17, danakj (behind on reviews) wrote: > mailto:+tsepez@chromium.org for ipc/ changing Pass() to ...
5 years ago (2015-11-27 17:11:30 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/180001
5 years ago (2015-11-30 19:43:36 UTC) #66
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/102826) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years ago (2015-11-30 21:43:08 UTC) #68
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/200001
5 years ago (2015-11-30 22:00:28 UTC) #72
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/141747)
5 years ago (2015-12-01 00:01:17 UTC) #74
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/200001
5 years ago (2015-12-01 00:14:41 UTC) #76
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/142611)
5 years ago (2015-12-01 01:13:29 UTC) #79
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/220001
5 years ago (2015-12-01 01:14:34 UTC) #80
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/123383)
5 years ago (2015-12-01 01:44:58 UTC) #82
danakj
+rohitrao@chromium.org for ios/
5 years ago (2015-12-01 19:14:42 UTC) #84
rohitrao (ping after 24h)
ios LGTM
5 years ago (2015-12-01 19:15:50 UTC) #87
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/220001
5 years ago (2015-12-01 19:16:21 UTC) #88
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/101272)
5 years ago (2015-12-01 20:51:51 UTC) #91
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/240001
5 years ago (2015-12-01 22:20:13 UTC) #95
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/148418)
5 years ago (2015-12-02 00:55:30 UTC) #97
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/240001
5 years ago (2015-12-02 23:26:48 UTC) #99
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/130386)
5 years ago (2015-12-03 00:59:45 UTC) #101
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/240001
5 years ago (2015-12-03 01:07:16 UTC) #103
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/130443) win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years ago (2015-12-03 01:58:06 UTC) #105
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/240001
5 years ago (2015-12-03 18:31:13 UTC) #107
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/74998)
5 years ago (2015-12-03 21:16:49 UTC) #109
danakj
So this is really weird. On the Win8 bot it causes this error: e:\b\build\slave\win_gn\build\src\media\mojo\services\media_type_converters.cc(297) :error ...
5 years ago (2015-12-03 21:19:37 UTC) #110
danakj
I think I can undo the changes in media/ for this CL, they were part ...
5 years ago (2015-12-03 21:26:22 UTC) #111
jamesr
On 2015/12/03 at 21:26:22, danakj wrote: > I think I can undo the changes in ...
5 years ago (2015-12-03 21:27:37 UTC) #112
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/260001
5 years ago (2015-12-03 21:34:03 UTC) #115
jamesr
https://connect.microsoft.com/VisualStudio/feedback/details/1105046 is the bug I'm thinking of. Microsoft says that particular bug is fixed in ...
5 years ago (2015-12-03 21:39:16 UTC) #116
danakj
I think the mojo problem is a combination of this bug: https://connect.microsoft.com/VisualStudio/feedback/details/1105046 Which says visual ...
5 years ago (2015-12-03 21:45:33 UTC) #117
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL) win_chromium_compile_dbg_ng on ...
5 years ago (2015-12-03 23:39:30 UTC) #119
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/260001
5 years ago (2015-12-03 23:52:13 UTC) #121
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/87265)
5 years ago (2015-12-04 03:21:49 UTC) #123
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1477643002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1477643002/260001
5 years ago (2015-12-04 18:43:32 UTC) #125
commit-bot: I haz the power
Committed patchset #14 (id:260001)
5 years ago (2015-12-04 20:12:38 UTC) #127
commit-bot: I haz the power
5 years ago (2015-12-04 20:13:55 UTC) #129
Message was sent while issue was closed.
Patchset 14 (id:??) landed as
https://crrev.com/4b041ab3706e1c26bf105617750353ec111cf18b
Cr-Commit-Position: refs/heads/master@{#363281}

Powered by Google App Engine
This is Rietveld 408576698