Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: base/trace_event/trace_config.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_buffer.cc ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_config.cc
diff --git a/base/trace_event/trace_config.cc b/base/trace_event/trace_config.cc
index 7124bea8bf6a1cb0ea1a4bbbf29dfc4b52287c6c..fbe7e68e42f0d451ec3178554fad2ea625698bbd 100644
--- a/base/trace_event/trace_config.cc
+++ b/base/trace_event/trace_config.cc
@@ -4,6 +4,8 @@
#include "base/trace_event/trace_config.h"
+#include <utility>
+
#include "base/json/json_reader.h"
#include "base/json/json_writer.h"
#include "base/strings/pattern.h"
@@ -466,7 +468,7 @@ void TraceConfig::AddCategoryToDict(base::DictionaryValue& dict,
list->AppendString(*ci);
}
- dict.Set(param, list.Pass());
+ dict.Set(param, std::move(list));
}
void TraceConfig::SetMemoryDumpConfig(
@@ -558,13 +560,13 @@ void TraceConfig::ToDict(base::DictionaryValue& dict) const {
static_cast<int>(config.periodic_interval_ms));
trigger_dict->SetString(
kModeParam, MemoryDumpLevelOfDetailToString(config.level_of_detail));
- triggers_list->Append(trigger_dict.Pass());
+ triggers_list->Append(std::move(trigger_dict));
}
// Empty triggers will still be specified explicitly since it means that
// the periodic dumps are not enabled.
- memory_dump_config->Set(kTriggersParam, triggers_list.Pass());
- dict.Set(kMemoryDumpConfigParam, memory_dump_config.Pass());
+ memory_dump_config->Set(kTriggersParam, std::move(triggers_list));
+ dict.Set(kMemoryDumpConfigParam, std::move(memory_dump_config));
}
}
« no previous file with comments | « base/trace_event/trace_buffer.cc ('k') | base/trace_event/trace_event_argument.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698