Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3150)

Unified Diff: base/containers/scoped_ptr_map.h

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/containers/scoped_ptr_hash_map.h ('k') | base/containers/scoped_ptr_map_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/containers/scoped_ptr_map.h
diff --git a/base/containers/scoped_ptr_map.h b/base/containers/scoped_ptr_map.h
index dfa26f4febeaf8d5a16570caaf93852419bc9bb2..822cbfd0ebd12a215d967c9aa582cacc21cd8344 100644
--- a/base/containers/scoped_ptr_map.h
+++ b/base/containers/scoped_ptr_map.h
@@ -116,7 +116,7 @@ class ScopedPtrMap {
ScopedPtr ret(position->second);
// Key-based lookup (cannot use const_iterator overload in C++03 library).
data_.erase(position->first);
- return ret.Pass();
+ return ret;
}
// Like |erase()|, but returns the element instead of deleting it.
@@ -127,7 +127,7 @@ class ScopedPtrMap {
ScopedPtr ret(it->second);
data_.erase(it);
- return ret.Pass();
+ return ret;
}
private:
« no previous file with comments | « base/containers/scoped_ptr_hash_map.h ('k') | base/containers/scoped_ptr_map_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698