base/environment.cc - Issue 1479473002: base: Use std::move() instead of Pass() for real movable types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/environment.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: basepass: missing-include Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/environment.cc

diff --git a/base/environment.cc b/base/environment.cc

index 11b2bc39a9e0600741fb55559ca609c44da3641a..ca24ac70997a9a0de94fe320e46cb10ecbc6068d 100644

--- a/base/environment.cc

+++ b/base/environment.cc

@@ -228,7 +228,7 @@ scoped_ptr<char*[]> AlterEnvironment(const char* const* const env,

result[i] = &storage_data[result_indices[i]];

result[result_indices.size()] = 0; // Null terminator.

- return result.Pass();

+ return result;

}

#endif // OS_POSIX

« no previous file with comments | « base/containers/scoped_ptr_map_unittest.cc ('k') | base/environment_unittest.cc » ('j') | no next file with comments »