Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: base/trace_event/trace_event_argument_unittest.cc

Issue 1479473002: base: Use std::move() instead of Pass() for real movable types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: basepass: missing-include Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | base/trace_event/trace_event_memory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_argument_unittest.cc
diff --git a/base/trace_event/trace_event_argument_unittest.cc b/base/trace_event/trace_event_argument_unittest.cc
index c1233ac3a3c85d60a50e80746dde6a280ba40569..c9ccdb47ce4dc748e2f182da12f80b417e666de2 100644
--- a/base/trace_event/trace_event_argument_unittest.cc
+++ b/base/trace_event/trace_event_argument_unittest.cc
@@ -3,6 +3,9 @@
// found in the LICENSE file.
#include "base/trace_event/trace_event_argument.h"
+
+#include <utility>
+
#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -106,11 +109,11 @@ TEST(TraceEventArgumentTest, PassBaseValue) {
list_value->AppendBoolean(false);
list_value->AppendInteger(1);
list_value->AppendString("in_list");
- list_value->Append(dict_value.Pass());
+ list_value->Append(std::move(dict_value));
scoped_refptr<TracedValue> value = new TracedValue();
value->BeginDictionary("outer_dict");
- value->SetValue("inner_list", list_value.Pass());
+ value->SetValue("inner_list", std::move(list_value));
value->EndDictionary();
dict_value.reset();
« no previous file with comments | « base/trace_event/trace_event_argument.cc ('k') | base/trace_event/trace_event_memory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698