Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1420033002: Revert of Add version string and force highp NDS transfrom to GLSLCaps (Closed)

Created:
5 years, 2 months ago by egdaniel
Modified:
5 years, 2 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@renameShaderVar
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add version string and force highp NDS transfrom to GLSLCaps (patchset #3 id:40001 of https://codereview.chromium.org/1417993004/ ) Reason for revert: breaking bots Original issue's description: > Add version string and force highp NDS transfrom to GLSLCaps > > This also include the use of any() in the shaders. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/cef4bce8e260b49bf3417eadbac806cf7d39cdc8 TBR=bsalomon@google.com,jvanverth@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/899ba37db336c20a06bce65d952e0664596a26ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -173 lines) Patch
M bench/GLInstancedArraysBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLVec4ScalarBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M bench/GLVertexAttributesBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +81 lines, -142 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGLSL.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.h View 3 chunks +0 lines, -10 lines 0 comments Download
M src/gpu/glsl/GrGLSLCaps.cpp View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Add version string and force highp NDS transfrom to GLSLCaps
5 years, 2 months ago (2015-10-22 14:08:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420033002/1
5 years, 2 months ago (2015-10-22 14:08:25 UTC) #2
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 14:08:39 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/899ba37db336c20a06bce65d952e0664596a26ef

Powered by Google App Engine
This is Rietveld 408576698