Remove the "horizontal-bt" value from -webkit-writing-mode

Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that also had vertical-rl were removed. 2 tests
were converted to ref tests.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizontal-bt/blink-dev/JtBudxkQPfg/ltvv70WdCAAJ

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
Committed: https://crrev.com/405a1676fea008a94841d25a21ec1c13e156a831
Cr-Commit-Position: refs/heads/master@{#357306}

[kojii, 2015-10-30 01:57:54]

Description was changed from

==========
horizontal-bt

BUG=
==========

to

==========
horizontal-bt

BUG=533448
==========

[kojii, 2015-10-30 07:31:45]

Description was changed from

==========
horizontal-bt

BUG=533448
==========

to

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never got into the spec[1].

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

[kojii, 2015-10-30 13:05:10]

Description was changed from

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never got into the spec[1].

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

to

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that had vertical-rl were removed. 2 tests were
converted to ref tests.
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

[kojii, 2015-10-30 13:05:30]

Description was changed from

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that had vertical-rl were removed. 2 tests were
converted to ref tests.
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

to

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that had vertical-rl were removed. 2 tests were
converted to ref tests.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

[kojii, 2015-10-30 13:10:26]

kojii@chromium.org changed reviewers:
+ eae@chromium.org, timloh@chromium.org

[kojii, 2015-10-30 13:10:27]

PTAL.
eae@, please review layout & platform.
tim@, please review css & style.

ASAN and win failures do not seem to be related, I'll re-run the bots.

There are some "horizontal-bt" still in tests after this CL, but they pass,
indicating those tests are not really testing flipped block flows. I'll cleanup
them in following patches.

[kojii, 2015-10-30 13:12:57]

Description was changed from

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that had vertical-rl were removed. 2 tests were
converted to ref tests.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

to

==========
Remove the "horizontal-bt" value from -webkit-writing-mode

This patch removes the "horizontal-bt" value. This value was proposed a
few times in the past, but has never made into the spec[1].

Flexbox was using this value internally to calculate logical values for
column flows, which was converted to use TransformedWritingMode.

Tests and expected files were reduced by ~6k lines. Tests that used
horizontal-bt to test flipped block flow were changed to use
vertical-rl, and tests that also had vertical-rl were removed. 2 tests
were converted to ref tests.

Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/horizonta...

[1] https://drafts.csswg.org/css-writing-modes-3/#propdef-writing-mode

BUG=533448
==========

[cbiesinger, 2015-10-30 19:11:01]

cbiesinger@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[cbiesinger, 2015-10-30 19:11:03]

https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:465: return
static_cast<TransformedWritingMode>(mode);
That seems a little scary, maybe add some COMPILE_ASSERTs to ensure that the
values are the same between the two enums?

[eae, 2015-11-01 06:49:58]

layout/ and platform/ LGTM, agree with cbiesinger about adding an assert.

[kojii, 2015-11-01 06:58:55]

Done, mac bot seems to be broken, I'll re-run when it's back.

https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:465: return
static_cast<TransformedWritingMode>(mode);
On 2015/10/30 at 19:11:02, cbiesinger wrote:
> That seems a little scary, maybe add some COMPILE_ASSERTs to ensure that the
values are the same between the two enums?

Added static_assert, thank you for the advice.

[eae, 2015-11-01 07:05:09]

On 2015/11/01 06:58:55, kojii wrote:
> Done, mac bot seems to be broken, I'll re-run when it's back.
> 
>
https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):
> 
>
https://codereview.chromium.org/1419813004/diff/120001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:465: return
> static_cast<TransformedWritingMode>(mode);
> On 2015/10/30 at 19:11:02, cbiesinger wrote:
> > That seems a little scary, maybe add some COMPILE_ASSERTs to ensure that the
> values are the same between the two enums?
> 
> Added static_assert, thank you for the advice.

Saw that, thank you!
Please wait for Timothy to review the css changes before landing.

[Timothy Loh, 2015-11-01 23:29:35]

lgtm

[kojii, 2015-11-02 03:17:39]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2015-11-02 03:18:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1419813004/20002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1419813004/20002

[commit-bot: I haz the power, 2015-11-02 04:32:34]

Committed patchset #8 (id:20002)

[commit-bot: I haz the power, 2015-11-02 04:33:35]

Patchset 8 (id:??) landed as
https://crrev.com/405a1676fea008a94841d25a21ec1c13e156a831
Cr-Commit-Position: refs/heads/master@{#357306}