third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp

index cf64955eaec4fdf6ddcbec49765f1d818c9c45ae..acab5024299505368a440176f9a2aefecc5dd245 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp

@@ -50,11 +50,8 @@ LayoutDetailsMarker::Orientation LayoutDetailsMarker::orientation() const

if (style()->isLeftToRightDirection())

return isOpen() ? Right : Down;

return isOpen() ? Right : Up;

- case BottomToTopWritingMode:

- if (style()->isLeftToRightDirection())

- return isOpen() ? Up : Right;

- return isOpen() ? Up : Left;

}

+ ASSERT_NOT_REACHED();

return Right;

}

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h » ('j') | no next file with comments »