third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutDetailsMarker.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

index 661cd9a3529962a1aed647febf843bccf8329afc..efe8cd72d34865042a9f1c8bc71ed2dd2b92a069 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

+++ b/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h

@@ -83,6 +83,10 @@ private:

NeverLayout

};

+ enum class TransformedWritingMode {

+ TopToBottomWritingMode, RightToLeftWritingMode, LeftToRightWritingMode, BottomToTopWritingMode

+ };

typedef HashMap<const LayoutBox*, LayoutUnit> InflexibleFlexItemSize;

typedef Vector<LayoutBox*> OrderedFlexItemList;

@@ -107,7 +111,7 @@ private:

LayoutUnit crossAxisContentExtent() const;

LayoutUnit mainAxisContentExtent(LayoutUnit contentLogicalHeight);

LayoutUnit computeMainAxisExtentForChild(const LayoutBox& child, SizeType, const Length& size);

- WritingMode transformedWritingMode() const;

+ TransformedWritingMode transformedWritingMode() const;

LayoutUnit flowAwareBorderStart() const;

LayoutUnit flowAwareBorderEnd() const;

LayoutUnit flowAwareBorderBefore() const;