third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/ManualTests/caret-in-columns-flipped.html ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

index 01d98f7e696d9fbf08f45cb402c09c0dd3ebf7c0..7e7df4829d02a455a41f8da2aa18a059d989b8f6 100644

--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h

@@ -2668,9 +2668,6 @@ template<> inline CSSPrimitiveValue::CSSPrimitiveValue(WritingMode e)

case LeftToRightWritingMode:

m_value.valueID = CSSValueVerticalLr;

break;

- case BottomToTopWritingMode:

- m_value.valueID = CSSValueHorizontalBt;

- break;

}

@@ -2690,8 +2687,6 @@ template<> inline WritingMode CSSPrimitiveValue::convertTo() const

return RightToLeftWritingMode;

case CSSValueVerticalLr:

return LeftToRightWritingMode;

- case CSSValueHorizontalBt:

- return BottomToTopWritingMode;

default:

break;

}

« no previous file with comments | « third_party/WebKit/ManualTests/caret-in-columns-flipped.html ('k') | third_party/WebKit/Source/core/css/CSSProperty.cpp » ('j') | no next file with comments »