third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/LengthBox.cpp ('k') | third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

index a73594f888194d207275beb982dc9a6c8b1e3012..8a75ada79ccbee52872c92d10ec4b4419ae95ce6 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

+++ b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp

@@ -76,8 +76,6 @@ LayoutUnit LayoutRectOutsets::before(WritingMode writingMode) const

switch (writingMode) {

case TopToBottomWritingMode:

return m_top;

- case BottomToTopWritingMode:

- return m_bottom;

case LeftToRightWritingMode:

return m_left;

case RightToLeftWritingMode:

@@ -92,8 +90,6 @@ LayoutUnit LayoutRectOutsets::after(WritingMode writingMode) const

switch (writingMode) {

case TopToBottomWritingMode:

return m_bottom;

- case BottomToTopWritingMode:

- return m_top;

case LeftToRightWritingMode:

return m_right;

case RightToLeftWritingMode:

@@ -123,9 +119,6 @@ void LayoutRectOutsets::setBefore(WritingMode writingMode, LayoutUnit value)

case TopToBottomWritingMode:

m_top = value;

break;

- case BottomToTopWritingMode:

- m_bottom = value;

- break;

case LeftToRightWritingMode:

m_left = value;

break;

@@ -144,9 +137,6 @@ void LayoutRectOutsets::setAfter(WritingMode writingMode, LayoutUnit value)

case TopToBottomWritingMode:

m_bottom = value;

break;

- case BottomToTopWritingMode:

- m_top = value;

- break;

case LeftToRightWritingMode:

m_right = value;

break;