third_party/WebKit/Source/core/style/ComputedStyle.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.cpp ('k') | third_party/WebKit/Source/platform/LengthBox.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp

diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

index 6cef0714c8c54393249ab3155b0119353ac869b3..222c33205baa930c3adfa2e98fbc00881dbdb0b1 100644

--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp

+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp

@@ -1533,8 +1533,6 @@ const BorderValue& ComputedStyle::borderBefore() const

switch (writingMode()) {

case TopToBottomWritingMode:

return borderTop();

- case BottomToTopWritingMode:

- return borderBottom();

case LeftToRightWritingMode:

return borderLeft();

case RightToLeftWritingMode:

@@ -1549,8 +1547,6 @@ const BorderValue& ComputedStyle::borderAfter() const

switch (writingMode()) {

case TopToBottomWritingMode:

return borderBottom();

- case BottomToTopWritingMode:

- return borderTop();

case LeftToRightWritingMode:

return borderRight();

case RightToLeftWritingMode:

@@ -1579,8 +1575,6 @@ int ComputedStyle::borderBeforeWidth() const

switch (writingMode()) {

case TopToBottomWritingMode:

return borderTopWidth();

- case BottomToTopWritingMode:

- return borderBottomWidth();

case LeftToRightWritingMode:

return borderLeftWidth();

case RightToLeftWritingMode:

@@ -1595,8 +1589,6 @@ int ComputedStyle::borderAfterWidth() const

switch (writingMode()) {

case TopToBottomWritingMode:

return borderBottomWidth();

- case BottomToTopWritingMode:

- return borderTopWidth();

case LeftToRightWritingMode:

return borderRightWidth();

case RightToLeftWritingMode: