third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

index 104d7188378d44a3a431d2982cfe8c09bc5db38c..3b0046797503e6ed25a99da55128fd4ba6545c6c 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -688,7 +688,7 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyWebkitUserSelect: // auto | none | text | all

return valueID == CSSValueAuto || valueID == CSSValueNone || valueID == CSSValueText || valueID == CSSValueAll;

case CSSPropertyWebkitWritingMode:

- return valueID >= CSSValueHorizontalTb && valueID <= CSSValueHorizontalBt;

+ return valueID >= CSSValueHorizontalTb && valueID <= CSSValueVerticalLr;

case CSSPropertyWritingMode:

return valueID == CSSValueHorizontalTb

|| valueID == CSSValueVerticalRl || valueID == CSSValueVerticalLr

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSValueKeywords.in ('k') | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »