third_party/WebKit/Source/platform/LengthBox.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LengthBox.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/LengthBox.cpp

diff --git a/third_party/WebKit/Source/platform/LengthBox.cpp b/third_party/WebKit/Source/platform/LengthBox.cpp

index 5afe9d2a0bced38f3d15d19de31b81009b38ba04..071d67b5c0c6231762be54d1f9ce378c05a36ee6 100644

--- a/third_party/WebKit/Source/platform/LengthBox.cpp

+++ b/third_party/WebKit/Source/platform/LengthBox.cpp

@@ -48,8 +48,6 @@ const Length& LengthBox::before(WritingMode writingMode) const

switch (writingMode) {

case TopToBottomWritingMode:

return m_top;

- case BottomToTopWritingMode:

- return m_bottom;

case LeftToRightWritingMode:

return m_left;

case RightToLeftWritingMode:

@@ -64,8 +62,6 @@ const Length& LengthBox::after(WritingMode writingMode) const

switch (writingMode) {

case TopToBottomWritingMode:

return m_bottom;

- case BottomToTopWritingMode:

- return m_top;

case LeftToRightWritingMode:

return m_right;

case RightToLeftWritingMode: