third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp - Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp

Issue 1419813004: Remove the "horizontal-bt" value from -webkit-writing-mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add static_assert to ensure TransformedWritingMode matches to WritingMode Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/geometry/LayoutRectOutsets.cpp ('k') | third_party/WebKit/Source/platform/text/WritingMode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp

diff --git a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp

index 621e3d213dcd5f4c92f1f2ff324db4dac8ea7488..400f9b39546ff7a7dcb745780b82ec98c812a27e 100644

--- a/third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp

+++ b/third_party/WebKit/Source/platform/geometry/LayoutRectOutsetsTest.cpp

@@ -14,7 +14,6 @@ TEST(LayoutRectOutsetsTest, LogicalOutsets_Horizontal)

{

LayoutRectOutsets outsets(1, 2, 3, 4);

EXPECT_EQ(LayoutRectOutsets(1, 2, 3, 4), outsets.logicalOutsets(TopToBottomWritingMode));

- EXPECT_EQ(LayoutRectOutsets(1, 2, 3, 4), outsets.logicalOutsets(BottomToTopWritingMode));

}

TEST(LayoutRectOutsetsTest, LogicalOutsets_Vertical)

@@ -28,7 +27,6 @@ TEST(LayoutRectOutsetsTest, LogicalOutsetsWithFlippedLines)

{

LayoutRectOutsets outsets(1, 2, 3, 4);

EXPECT_EQ(LayoutRectOutsets(1, 2, 3, 4), outsets.logicalOutsetsWithFlippedLines(TopToBottomWritingMode));

- EXPECT_EQ(LayoutRectOutsets(3, 2, 1, 4), outsets.logicalOutsetsWithFlippedLines(BottomToTopWritingMode));

EXPECT_EQ(LayoutRectOutsets(2, 3, 4, 1), outsets.logicalOutsetsWithFlippedLines(LeftToRightWritingMode));

EXPECT_EQ(LayoutRectOutsets(4, 3, 2, 1), outsets.logicalOutsetsWithFlippedLines(RightToLeftWritingMode));

}