Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1417103002: Add ElementKind for factory constructors. (Closed)

Created:
5 years, 2 months ago by Johnni Winther
Modified:
5 years, 2 months ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -51 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 2 chunks +1 line, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_data.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
Main changes in elements/*.dart
5 years, 2 months ago (2015-10-21 11:19:08 UTC) #2
sigurdm
LGTM https://codereview.chromium.org/1417103002/diff/1/pkg/compiler/lib/src/parser/member_listener.dart File pkg/compiler/lib/src/parser/member_listener.dart (right): https://codereview.chromium.org/1417103002/diff/1/pkg/compiler/lib/src/parser/member_listener.dart#newcode117 pkg/compiler/lib/src/parser/member_listener.dart:117: Element memberElement = new PartialConstructorElement( I think it ...
5 years, 2 months ago (2015-10-21 14:12:26 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as eeab865f27eb22103869cc74ad8ca761a730420a (presubmit successful).
5 years, 2 months ago (2015-10-21 15:17:21 UTC) #4
Johnni Winther
5 years, 2 months ago (2015-10-21 17:49:49 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1417103002/diff/1/pkg/compiler/lib/src/parser...
File pkg/compiler/lib/src/parser/member_listener.dart (right):

https://codereview.chromium.org/1417103002/diff/1/pkg/compiler/lib/src/parser...
pkg/compiler/lib/src/parser/member_listener.dart:117: Element memberElement =
new PartialConstructorElement(
On 2015/10/21 14:12:26, sigurdm wrote:
> I think it would be nice to make PartialConstructorElement abstract and  have
> two subclasses: PartialGenerativeConstructorElement and
> PartialFactoryConstructorElement (and ideally create marker interfaces
> FactoryConstructorElement and GenerativeConstructorElement).
> Then the construction-site would not need to know about ElementKind. This
would
> be parallel to the current separation between GetterElement and SetterElement.

Good idea! Adding a TODO.

Powered by Google App Engine
This is Rietveld 408576698