Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: pkg/compiler/lib/src/serialization/modelz.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/serialization/modelz.dart
diff --git a/pkg/compiler/lib/src/serialization/modelz.dart b/pkg/compiler/lib/src/serialization/modelz.dart
index 86d27901124c18dd20507b6a25136b398f20b0b8..07cf4e6e7b537419dd8f3804ad6a8b7370e73232 100644
--- a/pkg/compiler/lib/src/serialization/modelz.dart
+++ b/pkg/compiler/lib/src/serialization/modelz.dart
@@ -51,9 +51,6 @@ Link toLink(Iterable iterable) {
}
abstract class ElementZ extends Element with ElementCommon {
- @override
- bool get isFactoryConstructor => false;
-
String toString() {
if (enclosingElement == null || isTopLevel) return 'Z$kind($name)';
return 'Z$kind(${enclosingElement.name}#$name)';
@@ -1006,10 +1003,7 @@ class FactoryConstructorElementZ extends ConstructorElementZ {
: super(decoder);
@override
- ElementKind get kind => ElementKind.FUNCTION;
-
- @override
- bool get isFactoryConstructor => true;
+ ElementKind get kind => ElementKind.FACTORY_CONSTRUCTOR;
}
abstract class MemberElementMixin
« no previous file with comments | « pkg/compiler/lib/src/resolution/resolution.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698