Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index bb00a2640caf363cc5a45d4592002585afbc3269..9498e56e3a935041b59ae7ca16e12cb819372d90 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -1145,18 +1145,18 @@ class SsaBuilder extends ast.Visitor
HGraph build() {
assert(invariant(target, target.isImplementation));
HInstruction.idCounter = 0;
- ElementKind kind = target.kind;
// TODO(sigmund): remove `result` and return graph directly, need to ensure
// that it can never be null (see result in buildFactory for instance).
var result;
- if (kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
+ if (target.isGenerativeConstructor) {
result = buildFactory(target);
- } else if (kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY ||
- kind == ElementKind.FUNCTION ||
- kind == ElementKind.GETTER ||
- kind == ElementKind.SETTER) {
+ } else if (target.isGenerativeConstructorBody ||
+ target.isFactoryConstructor ||
+ target.isFunction ||
+ target.isGetter ||
+ target.isSetter) {
result = buildMethod(target);
- } else if (kind == ElementKind.FIELD) {
+ } else if (target.isField) {
if (target.isInstanceMember) {
assert(compiler.enableTypeAssertions);
result = buildCheckedSetter(target);
@@ -1164,7 +1164,7 @@ class SsaBuilder extends ast.Visitor
result = buildLazyInitializer(target);
}
} else {
- reporter.internalError(target, 'Unexpected element kind $kind.');
+ reporter.internalError(target, 'Unexpected element kind $target.');
}
assert(result.isValid());
return result;
« no previous file with comments | « pkg/compiler/lib/src/serialization/modelz.dart ('k') | tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698