pkg/compiler/lib/src/resolution/members.dart - Issue 1417103002: Add ElementKind for factory constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/members.dart

diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart

index 90f536553150628ae9a9f676416195b3666297a0..d805d06faa4748ec6543f8b984fe65280632c24f 100644

--- a/pkg/compiler/lib/src/resolution/members.dart

+++ b/pkg/compiler/lib/src/resolution/members.dart

@@ -3758,7 +3758,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {

if (modifiers.isVar && (modifiers.isConst || node.type != null)) {

reportExtraModifier('var');

}

- if (enclosingElement.isFunction) {

+ if (enclosingElement.isFunction || enclosingElement.isConstructor) {

if (modifiers.isAbstract) {

reportExtraModifier('abstract');

}