Add ElementKind for factory constructors.

pkg/compiler/lib/src/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of ssa;
 
 class SsaFunctionCompiler implements FunctionCompiler {
   final SsaCodeGeneratorTask generator;
   final SsaBuilderTask builder;
   final SsaOptimizerTask optimizer;
@@ skipping 1127 matching lines @@
   // implementation/declaration distinction.
   Element get sourceElement => sourceElementStack.last;
 
   bool get _checkOrTrustTypes =>
       compiler.enableTypeAssertions || compiler.trustTypeAnnotations;
 
   /// Build the graph for [target].
   HGraph build() {
     assert(invariant(target, target.isImplementation));
     HInstruction.idCounter = 0;
-    ElementKind kind = target.kind;
     // TODO(sigmund): remove `result` and return graph directly, need to ensure
     // that it can never be null (see result in buildFactory for instance).
     var result;
-    if (kind == ElementKind.GENERATIVE_CONSTRUCTOR) {
+    if (target.isGenerativeConstructor) {
       result = buildFactory(target);
-    } else if (kind == ElementKind.GENERATIVE_CONSTRUCTOR_BODY ||
-               kind == ElementKind.FUNCTION ||
-               kind == ElementKind.GETTER ||
-               kind == ElementKind.SETTER) {
+    } else if (target.isGenerativeConstructorBody ||
+               target.isFactoryConstructor ||
+               target.isFunction ||
+               target.isGetter ||
+               target.isSetter) {
       result = buildMethod(target);
-    } else if (kind == ElementKind.FIELD) {
+    } else if (target.isField) {
       if (target.isInstanceMember) {
         assert(compiler.enableTypeAssertions);
         result = buildCheckedSetter(target);
       } else {
         result = buildLazyInitializer(target);
       }
     } else {
-      reporter.internalError(target, 'Unexpected element kind $kind.');
+      reporter.internalError(target, 'Unexpected element kind $target.');
     }
     assert(result.isValid());
     return result;
   }
 
 
   HBasicBlock addNewBlock() {
     HBasicBlock block = graph.addNewBlock();
     // If adding a new block during building of an expression, it is due to
     // conditional expressions or short-circuit logical operators.
@@ skipping 7967 matching lines @@
     if (unaliased is TypedefType) throw 'unable to unalias $type';
     unaliased.accept(this, builder);
   }
 
   void visitDynamicType(DynamicType type, SsaBuilder builder) {
     JavaScriptBackend backend = builder.compiler.backend;
     ClassElement cls = backend.findHelper('DynamicRuntimeType');
     builder.push(new HDynamicType(type, new TypeMask.exact(cls, classWorld)));
   }
 }