Add ElementKind for factory constructors.

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 3697 matching lines @@
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) => new Class._(a, b);
           Class._(a, b);
         }
         m() => new Class(true, 42);
         ''',
         const Visit(VisitKind.VISIT_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class() => new Class._(true, 42);
           Class._(a, b);
         }
         m() => new Class(true, 42);
         ''',
         const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class<T> {
           factory Class(a, b) = Class<int>.a;
           factory Class.a(a, b) = Class<Class<T>>.b;
           Class.b(a, b);
         }
         m() => new Class<double>(true, 42);
         ''',
         const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class<double>',
             target: 'generative_constructor(Class#b)',
             targetType: 'Class<Class<int>>',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class<T> {
           factory Class(a) = Class<int>.a;
           factory Class.a(a, [b]) = Class<Class<T>>.b;
           Class.b(a, [b]);
         }
         m() => new Class<double>(true, 42);
         ''',
         const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class<double>',
             target: 'generative_constructor(Class#b)',
             targetType: 'Class<Class<int>>',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class() = Class._;
           Class._();
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class<T> {
           factory Class(a, b) = Class<int>.a;
           factory Class.a(a, b) = Class<Class<T>>.b;
           Class.b(a);
         }
         m() => new Class<double>(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class<double>',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           Class(a, b);
         }
         m() => new Class.unresolved(true, 42);
         ''',
@@ skipping 20 matching lines @@
             selector: 'CallStructure(arity=0)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Unresolved;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Class.named;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Class.named;
           factory Class.named(a, b) = Class.unresolved;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         abstract class AbstractClass {
           AbstractClass(a, b);
         }
         class Class {
           factory Class(a, b) = AbstractClass;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
-            element: 'function(Class#)',
+            element: 'factory_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
   ],
   'If not null expressions': const [
     const Test(
         '''
         m(a) => a?.b;
         ''',
         const [
@@ skipping 564 matching lines @@
             element: 'field(a)', rhs: '42')),
 
     const Test(
         '''
         m() => unresolved ??= 42;
         ''',
         const Visit(VisitKind.VISIT_UNRESOLVED_SET_IF_NULL,
             name: 'unresolved', rhs: '42')),
   ],
 };