Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3450)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_send_data.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test_decl_data.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test_send_data.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
index c407766d961ff4e5ac0c9d5e9b5a37107fa1c0d7..cd03cd875fd0a0071127db16ee88ffac938b182c 100644
--- a/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test_send_data.dart
@@ -3715,7 +3715,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => new Class(true, 42);
''',
const Visit(VisitKind.VISIT_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3728,7 +3728,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => new Class(true, 42);
''',
const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3742,7 +3742,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => new Class<double>(true, 42);
''',
const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class<double>',
target: 'generative_constructor(Class#b)',
@@ -3758,7 +3758,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
m() => new Class<double>(true, 42);
''',
const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class<double>',
target: 'generative_constructor(Class#b)',
@@ -3774,7 +3774,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3789,7 +3789,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class<double>',
selector: 'CallStructure(arity=2)')),
@@ -3830,7 +3830,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3843,7 +3843,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3857,7 +3857,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
@@ -3873,7 +3873,7 @@ const Map<String, List<Test>> SEND_TESTS = const {
''',
const Visit(
VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
- element: 'function(Class#)',
+ element: 'factory_constructor(Class#)',
arguments: '(true,42)',
type: 'Class',
selector: 'CallStructure(arity=2)')),
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test_decl_data.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698