tests/compiler/dart2js/semantic_visitor_test_decl_data.dart - Issue 1417103002: Add ElementKind for factory constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_decl_data.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/compiler/dart2js/js_backend_cps_ir_constructor_test.dart ('k') | tests/compiler/dart2js/semantic_visitor_test_send_data.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/compiler/dart2js/semantic_visitor_test_decl_data.dart

diff --git a/tests/compiler/dart2js/semantic_visitor_test_decl_data.dart b/tests/compiler/dart2js/semantic_visitor_test_decl_data.dart

index f31b688edd44ace6fa0e11abe0b2269320dea529..1019d8cfdbc3ec22e9c2d6fef73eaf96418d6b85 100644

--- a/tests/compiler/dart2js/semantic_visitor_test_decl_data.dart

+++ b/tests/compiler/dart2js/semantic_visitor_test_decl_data.dart

@@ -536,7 +536,7 @@ const Map<String, List<Test>> DECL_TESTS = const {

''',

const [

const Visit(VisitKind.VISIT_FACTORY_CONSTRUCTOR_DECL,

- element: 'function(C#)',

+ element: 'factory_constructor(C#)',

parameters: '(a,b)',

body: '=>null;'),

const Visit(VisitKind.VISIT_REQUIRED_PARAMETER_DECL,

@@ -556,7 +556,7 @@ const Map<String, List<Test>> DECL_TESTS = const {

''',

const [

const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,

- element: 'function(C#)',

+ element: 'factory_constructor(C#)',

parameters: '(a,b)',

target: 'generative_constructor(C#_)',

type: 'C'),

@@ -579,7 +579,7 @@ const Map<String, List<Test>> DECL_TESTS = const {

''',

const [

const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,

- element: 'function(C#)',

+ element: 'factory_constructor(C#)',

parameters: '(a,b)',

target: 'generative_constructor(D#)',

type: 'D'),

@@ -602,7 +602,7 @@ const Map<String, List<Test>> DECL_TESTS = const {

''',

const [

const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,

- element: 'function(C#)',

+ element: 'factory_constructor(C#)',

parameters: '(a,b)',

target: 'generative_constructor(D#)',

type: 'D<int>'),

@@ -628,9 +628,9 @@ const Map<String, List<Test>> DECL_TESTS = const {

''',

const [

const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,

- element: 'function(C#)',

+ element: 'factory_constructor(C#)',

parameters: '(a,b)',

- target: 'function(D#)',

+ target: 'factory_constructor(D#)',

type: 'D<int>'),

const Visit(VisitKind.VISIT_REQUIRED_PARAMETER_DECL,

element: 'parameter(#a)',