pkg/compiler/lib/src/elements/modelx.dart - Issue 1417103002: Add ElementKind for factory constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/elements/modelx.dart

Issue 1417103002: Add ElementKind for factory constructors. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/elements/modelx.dart

diff --git a/pkg/compiler/lib/src/elements/modelx.dart b/pkg/compiler/lib/src/elements/modelx.dart

index 6dfd7511605d8e24d9c4548f1c1b529cca755b6f..9c18aae86806b363e6f3798286ea48eaccfbf531 100644

--- a/pkg/compiler/lib/src/elements/modelx.dart

+++ b/pkg/compiler/lib/src/elements/modelx.dart

@@ -100,7 +100,6 @@ abstract class ElementX extends Element with ElementCommon {

bool get isInstanceMember => false;

bool get isDeferredLoaderGetter => false;

- bool get isFactoryConstructor => modifiers.isFactory;

bool get isConst => modifiers.isConst;

bool get isFinal => modifiers.isFinal;

bool get isStatic => modifiers.isStatic;

@@ -122,7 +121,7 @@ abstract class ElementX extends Element with ElementCommon {

bool get isAssignable {

if (isFinal || isConst) return false;

- if (isFunction || isGenerativeConstructor) return false;

+ if (isFunction || isConstructor) return false;

return true;

}