Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1415873011: Revert of Enable stencil clipping in mixed sampled render targets (patchset #6 id:100001 of https:/… (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Kimmo Kinnunen, nv_mark
Base URL:
https://skia.googlesource.com/skia.git@reverts2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Enable stencil clipping in mixed sampled render targets (patchset #6 id:100001 of https://codereview.chromium.org/1232103002/ ) Reason for revert: Co-centered sample locations are not needed to do stencil clip with mixed samples Original issue's description: > Implement stencil clipping in mixed sampled render targets > > This change enables multisampled clipping for mixed sampled > render targets. Previously clipping in mixed samples config > behaved the same as in the gpu config. > > In order to retrofit non-MSAA draw methods, programmable sample > locations are used in order to colocate all samples at (0.5, 0.5). > Requires support for NV_sample_locations. > > BUG=skia:4399 > > Committed: > https://skia.googlesource.com/skia/+/3e77ba96d56d15db30ac6d8ccb900e30aafcbb16 BUG=skia: Committed: https://skia.googlesource.com/skia/+/7e806f3f8a542bb6b2026a843de99a8640e2e87f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -88 lines) Patch
M include/gpu/GrCaps.h View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrCaps.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLDefines.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +3 lines, -29 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLRenderTarget.h View 2 chunks +0 lines, -19 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Chris Dalton
5 years, 1 month ago (2015-11-10 22:20:45 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-11 20:00:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1415873011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1415873011/1
5 years, 1 month ago (2015-11-11 23:04:22 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 23:16:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7e806f3f8a542bb6b2026a843de99a8640e2e87f

Powered by Google App Engine
This is Rietveld 408576698