Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1420883007: Revert of Fix setColocatedSampleLocations on ES and GL < 4.5 (patchset #2 id:20001 of https://coder… (Closed)

Created:
5 years, 1 month ago by Chris Dalton
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org, Kimmo Kinnunen, nv_mark
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix setColocatedSampleLocations on ES and GL < 4.5 (patchset #2 id:20001 of https://codereview.chromium.org/1415503008/ ) Reason for revert: Co-centered sample locations are not needed to do stencil clip with mixed samples. Original issue's description: > Fix setColocatedSampleLocations on ES and GL < 4.5 > > Updates setColocatedSampleLocations to use glFramebufferParameteri > when > the DSA version glNamedFramebufferParameteri is not present. > > BUG=skia: > > Committed: > https://skia.googlesource.com/skia/+/98cad6219b430eddf5528473311279f21dbd2e10 BUG=skia: Committed: https://skia.googlesource.com/skia/+/24ddb0a4ddbf4b576b2c8a6fc19765e00c3bd34d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -39 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLAssembleInterface.cpp View 2 chunks +0 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 chunk +3 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +3 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Chris Dalton
5 years, 1 month ago (2015-11-10 22:13:56 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-11-11 20:00:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1420883007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1420883007/1
5 years, 1 month ago (2015-11-11 22:52:52 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-11 23:03:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/24ddb0a4ddbf4b576b2c8a6fc19765e00c3bd34d

Powered by Google App Engine
This is Rietveld 408576698