Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed)

Created:
5 years, 1 month ago by Igor Sheludko
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[presubmit] Enabling readability/inheritance linter checking. Committed: https://crrev.com/7d7eee513a01127d1a822680768ee695442ebde5 Cr-Commit-Position: refs/heads/master@{#31785}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -346 lines) Patch
M src/ast.h View 14 chunks +14 lines, -25 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ast-expression-visitor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-literal-reindexer.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ast-numbering.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/code-stubs.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/crankshaft/hydrogen.h View 4 chunks +15 lines, -21 lines 0 comments Download
M src/crankshaft/hydrogen-instructions.h View 19 chunks +41 lines, -42 lines 0 comments Download
M src/crankshaft/typing.h View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 20 chunks +51 lines, -59 lines 0 comments Download
M src/full-codegen/full-codegen.h View 13 chunks +63 lines, -79 lines 0 comments Download
M src/heap/spaces.h View 1 6 chunks +11 lines, -10 lines 0 comments Download
M src/heap/spaces.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/ic.h View 2 chunks +4 lines, -6 lines 0 comments Download
M src/interface-descriptors.h View 1 chunk +6 lines, -6 lines 0 comments Download
M src/libplatform/default-platform.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/rewriter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner-character-streams.h View 6 chunks +21 lines, -21 lines 0 comments Download
M src/snapshot/serialize.h View 7 chunks +13 lines, -15 lines 0 comments Download
M src/snapshot/serialize.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M src/typing-asm.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/unittests/base/platform/condition-variable-unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M test/unittests/base/platform/semaphore-unittest.cc View 1 3 chunks +3 lines, -6 lines 0 comments Download
M test/unittests/libplatform/task-queue-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/unittests/run-all-unittests.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tools/presubmit.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 24 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223018/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223018/1
5 years, 1 month ago (2015-11-03 17:15:05 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/9748) v8_linux_mips64el_compile_rel on ...
5 years, 1 month ago (2015-11-03 17:17:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223018/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223018/20001
5 years, 1 month ago (2015-11-03 17:30:57 UTC) #6
Igor Sheludko
PTAL and CQ
5 years, 1 month ago (2015-11-03 17:47:54 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 17:54:02 UTC) #10
Michael Starzinger
LGTM, but you will need owners stamp for "crankshaft" and "snapshot". https://codereview.chromium.org/1412223018/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): ...
5 years, 1 month ago (2015-11-04 09:18:26 UTC) #11
Yang
On 2015/11/04 09:18:26, Michael Starzinger wrote: > LGTM, but you will need owners stamp for ...
5 years, 1 month ago (2015-11-04 09:49:21 UTC) #12
Igor Sheludko
Toon, PTAL crankshaft and snapshot parts. https://codereview.chromium.org/1412223018/diff/20001/src/heap/spaces.cc File src/heap/spaces.cc (right): https://codereview.chromium.org/1412223018/diff/20001/src/heap/spaces.cc#newcode2939 src/heap/spaces.cc:2939: On 2015/11/04 09:18:25, ...
5 years, 1 month ago (2015-11-04 09:51:57 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223018/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223018/40001
5 years, 1 month ago (2015-11-04 09:52:29 UTC) #16
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 10:11:34 UTC) #18
Toon Verwaest
lgtm
5 years, 1 month ago (2015-11-04 13:06:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1412223018/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1412223018/40001
5 years, 1 month ago (2015-11-04 13:07:10 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-04 13:08:34 UTC) #23
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 13:08:52 UTC) #24
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7d7eee513a01127d1a822680768ee695442ebde5
Cr-Commit-Position: refs/heads/master@{#31785}

Powered by Google App Engine
This is Rietveld 408576698