Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/elements.cc

Issue 1412223018: [presubmit] Enabling readability/inheritance linter checking. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressing comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/crankshaft/typing.h ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index 6b20c134d09b0e42c1653ea8c4fed5a69e514b98..715ecfb60a5fd5deb1d967449f8b38aab7385036 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -506,9 +506,8 @@ class ElementsAccessorBase : public ElementsAccessor {
ElementsAccessorSubclass::ValidateImpl(holder);
}
- virtual bool IsPacked(Handle<JSObject> holder,
- Handle<FixedArrayBase> backing_store, uint32_t start,
- uint32_t end) final {
+ bool IsPacked(Handle<JSObject> holder, Handle<FixedArrayBase> backing_store,
+ uint32_t start, uint32_t end) final {
return ElementsAccessorSubclass::IsPackedImpl(holder, backing_store, start,
end);
}
@@ -544,9 +543,9 @@ class ElementsAccessorBase : public ElementsAccessor {
}
}
- virtual bool HasElement(Handle<JSObject> holder, uint32_t index,
- Handle<FixedArrayBase> backing_store,
- PropertyAttributes filter) final {
+ bool HasElement(Handle<JSObject> holder, uint32_t index,
+ Handle<FixedArrayBase> backing_store,
+ PropertyAttributes filter) final {
return ElementsAccessorSubclass::HasElementImpl(holder, index,
backing_store, filter);
}
@@ -558,8 +557,8 @@ class ElementsAccessorBase : public ElementsAccessor {
*holder, *backing_store, index, filter) != kMaxUInt32;
}
- virtual Handle<Object> Get(Handle<FixedArrayBase> backing_store,
- uint32_t entry) final {
+ Handle<Object> Get(Handle<FixedArrayBase> backing_store,
+ uint32_t entry) final {
return ElementsAccessorSubclass::GetImpl(backing_store, entry);
}
@@ -569,8 +568,7 @@ class ElementsAccessorBase : public ElementsAccessor {
return BackingStore::get(Handle<BackingStore>::cast(backing_store), index);
}
- virtual void Set(FixedArrayBase* backing_store, uint32_t entry,
- Object* value) final {
+ void Set(FixedArrayBase* backing_store, uint32_t entry, Object* value) final {
ElementsAccessorSubclass::SetImpl(backing_store, entry, value);
}
@@ -585,10 +583,9 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual void Reconfigure(Handle<JSObject> object,
- Handle<FixedArrayBase> store, uint32_t entry,
- Handle<Object> value,
- PropertyAttributes attributes) final {
+ void Reconfigure(Handle<JSObject> object, Handle<FixedArrayBase> store,
+ uint32_t entry, Handle<Object> value,
+ PropertyAttributes attributes) final {
ElementsAccessorSubclass::ReconfigureImpl(object, store, entry, value,
attributes);
}
@@ -600,9 +597,8 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual void Add(Handle<JSObject> object, uint32_t index,
- Handle<Object> value, PropertyAttributes attributes,
- uint32_t new_capacity) final {
+ void Add(Handle<JSObject> object, uint32_t index, Handle<Object> value,
+ PropertyAttributes attributes, uint32_t new_capacity) final {
ElementsAccessorSubclass::AddImpl(object, index, value, attributes,
new_capacity);
}
@@ -613,9 +609,8 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual uint32_t Push(Handle<JSArray> receiver,
- Handle<FixedArrayBase> backing_store, Arguments* args,
- uint32_t push_size) final {
+ uint32_t Push(Handle<JSArray> receiver, Handle<FixedArrayBase> backing_store,
+ Arguments* args, uint32_t push_size) final {
return ElementsAccessorSubclass::PushImpl(receiver, backing_store, args,
push_size);
}
@@ -627,9 +622,9 @@ class ElementsAccessorBase : public ElementsAccessor {
return 0;
}
- virtual uint32_t Unshift(Handle<JSArray> receiver,
- Handle<FixedArrayBase> backing_store,
- Arguments* args, uint32_t unshift_size) final {
+ uint32_t Unshift(Handle<JSArray> receiver,
+ Handle<FixedArrayBase> backing_store, Arguments* args,
+ uint32_t unshift_size) final {
return ElementsAccessorSubclass::UnshiftImpl(receiver, backing_store, args,
unshift_size);
}
@@ -641,9 +636,9 @@ class ElementsAccessorBase : public ElementsAccessor {
return 0;
}
- virtual Handle<JSArray> Slice(Handle<JSObject> receiver,
- Handle<FixedArrayBase> backing_store,
- uint32_t start, uint32_t end) final {
+ Handle<JSArray> Slice(Handle<JSObject> receiver,
+ Handle<FixedArrayBase> backing_store, uint32_t start,
+ uint32_t end) final {
return ElementsAccessorSubclass::SliceImpl(receiver, backing_store, start,
end);
}
@@ -655,10 +650,10 @@ class ElementsAccessorBase : public ElementsAccessor {
return Handle<JSArray>();
}
- virtual Handle<JSArray> Splice(Handle<JSArray> receiver,
- Handle<FixedArrayBase> backing_store,
- uint32_t start, uint32_t delete_count,
- Arguments* args, uint32_t add_count) final {
+ Handle<JSArray> Splice(Handle<JSArray> receiver,
+ Handle<FixedArrayBase> backing_store, uint32_t start,
+ uint32_t delete_count, Arguments* args,
+ uint32_t add_count) final {
return ElementsAccessorSubclass::SpliceImpl(receiver, backing_store, start,
delete_count, args, add_count);
}
@@ -671,8 +666,8 @@ class ElementsAccessorBase : public ElementsAccessor {
return Handle<JSArray>();
}
- virtual Handle<Object> Pop(Handle<JSArray> receiver,
- Handle<FixedArrayBase> backing_store) final {
+ Handle<Object> Pop(Handle<JSArray> receiver,
+ Handle<FixedArrayBase> backing_store) final {
return ElementsAccessorSubclass::PopImpl(receiver, backing_store);
}
@@ -682,8 +677,8 @@ class ElementsAccessorBase : public ElementsAccessor {
return Handle<Object>();
}
- virtual Handle<Object> Shift(Handle<JSArray> receiver,
- Handle<FixedArrayBase> backing_store) final {
+ Handle<Object> Shift(Handle<JSArray> receiver,
+ Handle<FixedArrayBase> backing_store) final {
return ElementsAccessorSubclass::ShiftImpl(receiver, backing_store);
}
@@ -693,7 +688,7 @@ class ElementsAccessorBase : public ElementsAccessor {
return Handle<Object>();
}
- virtual void SetLength(Handle<JSArray> array, uint32_t length) final {
+ void SetLength(Handle<JSArray> array, uint32_t length) final {
ElementsAccessorSubclass::SetLengthImpl(array, length,
handle(array->elements()));
}
@@ -813,12 +808,12 @@ class ElementsAccessorBase : public ElementsAccessor {
}
}
- virtual void GrowCapacityAndConvert(Handle<JSObject> object,
- uint32_t capacity) final {
+ void GrowCapacityAndConvert(Handle<JSObject> object,
+ uint32_t capacity) final {
ElementsAccessorSubclass::GrowCapacityAndConvertImpl(object, capacity);
}
- virtual void Delete(Handle<JSObject> obj, uint32_t entry) final {
+ void Delete(Handle<JSObject> obj, uint32_t entry) final {
ElementsAccessorSubclass::DeleteImpl(obj, entry);
}
@@ -829,9 +824,9 @@ class ElementsAccessorBase : public ElementsAccessor {
UNREACHABLE();
}
- virtual void CopyElements(Handle<FixedArrayBase> from, uint32_t from_start,
- ElementsKind from_kind, Handle<FixedArrayBase> to,
- uint32_t to_start, int copy_size) final {
+ void CopyElements(Handle<FixedArrayBase> from, uint32_t from_start,
+ ElementsKind from_kind, Handle<FixedArrayBase> to,
+ uint32_t to_start, int copy_size) final {
DCHECK(!from.is_null());
// NOTE: the ElementsAccessorSubclass::CopyElementsImpl() methods
// violate the handlified function signature convention:
@@ -844,9 +839,9 @@ class ElementsAccessorBase : public ElementsAccessor {
kPackedSizeNotKnown, copy_size);
}
- virtual void CopyElements(JSObject* from_holder, uint32_t from_start,
- ElementsKind from_kind, Handle<FixedArrayBase> to,
- uint32_t to_start, int copy_size) final {
+ void CopyElements(JSObject* from_holder, uint32_t from_start,
+ ElementsKind from_kind, Handle<FixedArrayBase> to,
+ uint32_t to_start, int copy_size) final {
int packed_size = kPackedSizeNotKnown;
bool is_packed = IsFastPackedElementsKind(from_kind) &&
from_holder->IsJSArray();
@@ -892,18 +887,17 @@ class ElementsAccessorBase : public ElementsAccessor {
}
}
- virtual void CollectElementIndices(Handle<JSObject> object,
- Handle<FixedArrayBase> backing_store,
- KeyAccumulator* keys, uint32_t range,
- PropertyAttributes filter,
- uint32_t offset) final {
+ void CollectElementIndices(Handle<JSObject> object,
+ Handle<FixedArrayBase> backing_store,
+ KeyAccumulator* keys, uint32_t range,
+ PropertyAttributes filter, uint32_t offset) final {
ElementsAccessorSubclass::CollectElementIndicesImpl(
object, backing_store, keys, range, filter, offset);
};
- virtual void AddElementsToKeyAccumulator(Handle<JSObject> receiver,
- KeyAccumulator* accumulator,
- AddKeyConversion convert) final {
+ void AddElementsToKeyAccumulator(Handle<JSObject> receiver,
+ KeyAccumulator* accumulator,
+ AddKeyConversion convert) final {
Handle<FixedArrayBase> from(receiver->elements());
uint32_t add_length =
ElementsAccessorSubclass::GetCapacityImpl(*receiver, *from);
@@ -924,8 +918,7 @@ class ElementsAccessorBase : public ElementsAccessor {
return backing_store->length();
}
- virtual uint32_t GetCapacity(JSObject* holder,
- FixedArrayBase* backing_store) final {
+ uint32_t GetCapacity(JSObject* holder, FixedArrayBase* backing_store) final {
return ElementsAccessorSubclass::GetCapacityImpl(holder, backing_store);
}
@@ -955,9 +948,8 @@ class ElementsAccessorBase : public ElementsAccessor {
}
}
- virtual uint32_t GetEntryForIndex(JSObject* holder,
- FixedArrayBase* backing_store,
- uint32_t index) final {
+ uint32_t GetEntryForIndex(JSObject* holder, FixedArrayBase* backing_store,
+ uint32_t index) final {
return ElementsAccessorSubclass::GetEntryForIndexImpl(holder, backing_store,
index, NONE);
}
@@ -967,8 +959,8 @@ class ElementsAccessorBase : public ElementsAccessor {
return PropertyDetails(NONE, DATA, 0, PropertyCellType::kNoCell);
}
- virtual PropertyDetails GetDetails(FixedArrayBase* backing_store,
- uint32_t entry) final {
+ PropertyDetails GetDetails(FixedArrayBase* backing_store,
+ uint32_t entry) final {
return ElementsAccessorSubclass::GetDetailsImpl(backing_store, entry);
}
« no previous file with comments | « src/crankshaft/typing.h ('k') | src/full-codegen/full-codegen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698